* [bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs.
@ 2024-03-20 21:34 David Elsing
2024-03-21 0:46 ` Skyler Ferris via Guix-patches via
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: David Elsing @ 2024-03-20 21:34 UTC (permalink / raw)
To: skyvine, 69923; +Cc: David Elsing
* gnu/packages/arcan.scm (arcan-sdl)[inputs]: Add glu, libglvnd and mesa.
---
Hello,
I found the problem: The glu, libglvnd and mesa packages are
additionally required, now the build succeeds.
Cheers,
David
gnu/packages/arcan.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/arcan.scm b/gnu/packages/arcan.scm
index 4ca76edbec..dfc211ae9c 100644
--- a/gnu/packages/arcan.scm
+++ b/gnu/packages/arcan.scm
@@ -171,7 +171,7 @@ (define-public arcan-sdl
(inputs
(modify-inputs (package-inputs arcan)
(delete "libdrm")
- (prepend sdl)))
+ (prepend glu libglvnd mesa sdl)))
(arguments
`(,@(ensure-keyword-arguments
(package-arguments arcan)
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs.
2024-03-20 21:34 [bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs David Elsing
@ 2024-03-21 0:46 ` Skyler Ferris via Guix-patches via
2024-03-21 1:17 ` [bug#69923] arcan-sdl Ahmad Draidi via Guix-patches via
2024-03-22 10:34 ` bug#69923: [PATCH] gnu: arcan-sdl: Add missing inputs Ludovic Courtès
2 siblings, 0 replies; 5+ messages in thread
From: Skyler Ferris via Guix-patches via @ 2024-03-21 0:46 UTC (permalink / raw)
To: 69923, david.elsing
Awesome! I just checked on my machine with the patch from 69866 and it
still builds with that patch applied. It'll be great to have another
package working!
Also, just to clarify, I believe you mentioned on the call that you
noticed that there was bundled source in this package which needs to be
addressed. Is that something that you were planning on working on?
Regards,
Skyler
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#69923] arcan-sdl
2024-03-20 21:34 [bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs David Elsing
2024-03-21 0:46 ` Skyler Ferris via Guix-patches via
@ 2024-03-21 1:17 ` Ahmad Draidi via Guix-patches via
2024-03-22 20:23 ` David Elsing
2024-03-22 10:34 ` bug#69923: [PATCH] gnu: arcan-sdl: Add missing inputs Ludovic Courtès
2 siblings, 1 reply; 5+ messages in thread
From: Ahmad Draidi via Guix-patches via @ 2024-03-21 1:17 UTC (permalink / raw)
To: 69923
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Hello,
I believe arcan-sdl is built as part of the arcan package. I think I was planning to deprecate and remove it later as part of my arcan rework patches, but never got around to it.
Is there a reason to keep it around and not use arcan? Perhaps it should be converted to an output for the main package instead, if there's a good reason?
What do you think?
Thanks,
Ahmad Draidi
[-- Attachment #2: Type: text/html, Size: 474 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#69923: [PATCH] gnu: arcan-sdl: Add missing inputs.
2024-03-20 21:34 [bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs David Elsing
2024-03-21 0:46 ` Skyler Ferris via Guix-patches via
2024-03-21 1:17 ` [bug#69923] arcan-sdl Ahmad Draidi via Guix-patches via
@ 2024-03-22 10:34 ` Ludovic Courtès
2 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2024-03-22 10:34 UTC (permalink / raw)
To: David Elsing; +Cc: 69923-done, skyvine
Hi,
David Elsing <david.elsing@posteo.net> skribis:
> * gnu/packages/arcan.scm (arcan-sdl)[inputs]: Add glu, libglvnd and mesa.
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#69923] arcan-sdl
2024-03-21 1:17 ` [bug#69923] arcan-sdl Ahmad Draidi via Guix-patches via
@ 2024-03-22 20:23 ` David Elsing
0 siblings, 0 replies; 5+ messages in thread
From: David Elsing @ 2024-03-22 20:23 UTC (permalink / raw)
To: Ahmad Draidi; +Cc: 69923
Hello,
Ahmad Draidi <a.r.draidi@redscript.org> writes:
> Is there a reason to keep it around and not use arcan? Perhaps it should be converted to an output for the main package instead, if
> there's a good reason?
I don't know what the motivation was to make a separate package with
SDL1 and just looked why the build failed. The main package is built
with SDL2, maybe that's the reason? Here is the original issue where
arcan was added, you should probably ask them:
https://issues.guix.gnu.org/34189.
Best,
David
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-22 20:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-20 21:34 [bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs David Elsing
2024-03-21 0:46 ` Skyler Ferris via Guix-patches via
2024-03-21 1:17 ` [bug#69923] arcan-sdl Ahmad Draidi via Guix-patches via
2024-03-22 20:23 ` David Elsing
2024-03-22 10:34 ` bug#69923: [PATCH] gnu: arcan-sdl: Add missing inputs Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).