[bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs.

[bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs.

[David Elsing]

* gnu/packages/arcan.scm (arcan-sdl)[inputs]: Add glu, libglvnd and mesa.
---
Hello,

I found the problem: The glu, libglvnd and mesa packages are
additionally required, now the build succeeds.

Cheers,
David
 gnu/packages/arcan.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/arcan.scm b/gnu/packages/arcan.scm
index 4ca76edbec..dfc211ae9c 100644
--- a/gnu/packages/arcan.scm
+++ b/gnu/packages/arcan.scm
@@ -171,7 +171,7 @@ (define-public arcan-sdl
     (inputs
      (modify-inputs (package-inputs arcan)
        (delete "libdrm")
-       (prepend sdl)))
+       (prepend glu libglvnd mesa sdl)))
     (arguments
      `(,@(ensure-keyword-arguments
           (package-arguments arcan)
-- 
2.41.0

[bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs.

[Skyler Ferris via Guix-patches via]

Awesome! I just checked on my machine with the patch from 69866 and it 
still builds with that patch applied. It'll be great to have another 
package working!

Also, just to clarify, I believe you mentioned on the call that you 
noticed that there was bundled source in this package which needs to be 
addressed. Is that something that you were planning on working on?

Regards,
Skyler

[bug#69923] arcan-sdl

[Ahmad Draidi via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hello,

I believe arcan-sdl is built as part of the arcan package. I think I was planning to deprecate and remove it later as part of my arcan rework patches, but never got around to it.

Is there a reason to keep it around and not use arcan? Perhaps it should be converted to an output for the main package instead, if there's a good reason?

What do you think?

Thanks,
Ahmad Draidi

[-- Attachment #2: Type: text/html, Size: 474 bytes --]

[bug#69923] arcan-sdl

[David Elsing]

Hello,

Ahmad Draidi <a.r.draidi@redscript.org> writes:

> Is there a reason to keep it around and not use arcan? Perhaps it should be converted to an output for the main package instead, if
> there's a good reason?

I don't know what the motivation was to make a separate package with
SDL1 and just looked why the build failed. The main package is built
with SDL2, maybe that's the reason? Here is the original issue where
arcan was added, you should probably ask them:
https://issues.guix.gnu.org/34189.

Best,
David

bug#69923: [PATCH] gnu: arcan-sdl: Add missing inputs.

[Ludovic Courtès]

Hi,

David Elsing <david.elsing@posteo.net> skribis:

> * gnu/packages/arcan.scm (arcan-sdl)[inputs]: Add glu, libglvnd and mesa.

Applied, thanks!

Ludo’.