From: Jelle Licht <jlicht@posteo.net>
To: Andy Tai <atai@atai.org>, 46376@debbugs.gnu.org
Subject: [bug#46376] [PATCH] gnu: tesseract-ocr: update to 4.1.1)
Date: Mon, 08 Feb 2021 22:36:43 +0100 [thread overview]
Message-ID: <86a6sep7h0.fsf@posteo.net> (raw)
In-Reply-To: <CAJsg1E8Md0KGfH0RHRVrWCVuw7kzwYT2yA9ZOuCWQ1GpzaeBnw@mail.gmail.com>
Hello Andy,
Thanks for working on this package! I was not able to cleanly apply any
of the patches, but that problem might be on my end though.
Something did seem to go wrong though, as I notice three patches that do
the same (from a quick glance).
I have some nitpicks, some of them more serious than others;
Andy Tai <atai@atai.org> writes:
> * gnu/packages/ocr.scm (tesseract-ocr): update to 4.1.1
^ This is usually capitalised.
> [snip]
> (define-public tesseract-ocr
> + ;; some useful commits beyond last official stable release in release branch
> + (let ((commit "97079fa353557af6df86fd20b5d2e0dff5d8d5df"))
> (package
> (name "tesseract-ocr")
> - (version "3.04.01")
> + (version "4.1.1")
^ Since we are not _actually_ using version 4.1.1, but a
later commit, you could use
`(git-version "4.1.1" revision commit)' here instead
> (source
> (origin
> (method git-fetch)
> (uri (git-reference
> (url "https://github.com/tesseract-ocr/tesseract")
> - (commit version)))
> - (file-name (git-file-name name version))
> + (commit commit)
> + ;; Fetch git submodules
> + (recursive? #t)))
Instead of stating what the code does, would you consider adding a
comment why this is needed?
> + (file-name (string-append name "-" version "-" commit "-checkout"))
^ You can use `(git-file-name name version)' here.
> (sha256
> - (base32 "0h1x4z1h86n2gwknd0wck6gykkp99bmm02lg4a47a698g4az6ybv"))))
> + (base32 "0axwla82fpzp86lc553wp3hk0fz5dylw4as0jbf4hkqcyajlbzp4"))))
> (build-system gnu-build-system)
> (inputs
> - `(("leptonica" ,leptonica)))
> + `( ("cairo" ,cairo)
> + ("icu" ,icu4c)
> + ("leptonica" ,leptonica)
> + ("pango" ,pango)))
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("autoconf-archive" ,autoconf-archive)
> + ("automake" ,automake)
> + ("googletest" ,googletest)
> + ("libtool" ,libtool)
> + ("pkg-config" ,pkg-config)))
> (arguments
> '(#:configure-flags
> (let ((leptonica (assoc-ref %build-inputs "leptonica")))
> - (list (string-append "LIBLEPT_HEADERSDIR=" leptonica "/include")))))
> + (list (string-append "LIBLEPT_HEADERSDIR=" leptonica "/include")))
> + ;; some test, applybox_test fails to build
> + #:tests? #f))
2 nits: Is it possible to patch or disable only the failing tests?
Is there a reason googletest is added if testing is subsequently disabled?
Thanks,
- Jelle
next prev parent reply other threads:[~2021-02-09 0:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 6:32 [bug#46377] [PATCH] gnu: tesseract-ocr: update to 4.1.1 Andy Tai
2021-02-08 6:42 ` [bug#46376] " Andy Tai
[not found] ` <handler.46376.B.161276666727875.ack@debbugs.gnu.org>
2021-02-08 6:51 ` [bug#46376] [PATCH] gnu: tesseract-ocr: update to 4.1.1) Andy Tai
2021-02-08 21:36 ` Jelle Licht [this message]
2021-02-08 23:14 ` Andy Tai
2021-02-09 11:56 ` Jelle Licht
2021-02-09 16:22 ` Andy Tai
2021-02-09 22:43 ` Jelle Licht
2021-02-09 22:53 ` Andy Tai
2021-02-10 7:52 ` Andy Tai
2021-02-11 0:00 ` Andy Tai
2021-02-11 10:48 ` Jelle Licht
2021-02-11 18:34 ` Andy Tai
2021-02-13 14:34 ` bug#46376: " Jelle Licht
2021-02-13 20:37 ` [bug#46376] " Andy Tai
[not found] ` <handler.46377.B.161277624811801.ack@debbugs.gnu.org>
2021-02-08 17:53 ` [bug#46377] Acknowledgement ([PATCH] " Andy Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a6sep7h0.fsf@posteo.net \
--to=jlicht@posteo.net \
--cc=46376@debbugs.gnu.org \
--cc=atai@atai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).