From: Jelle Licht <jlicht@posteo.net>
To: Andy Tai <atai@atai.org>
Cc: 46376@debbugs.gnu.org
Subject: [bug#46376] [PATCH] gnu: tesseract-ocr: update to 4.1.1)
Date: Tue, 09 Feb 2021 12:56:42 +0100 [thread overview]
Message-ID: <867dnhpi85.fsf@posteo.net> (raw)
In-Reply-To: <CAJsg1E_GNDOpWfHd-nUPVk7VuAgfSFcUnG-tEZQGy-utzrPcTA@mail.gmail.com>
Hello Andy,
I have some additional questions about your updated patch.
Andy Tai <atai@atai.org> writes:
> updated patch attached
>> > - (file-name (git-file-name name version))
>> > + (commit commit)
>> > + ;; Fetch git submodules
>> > + (recursive? #t)))
>>
>> Instead of stating what the code does, would you consider adding a
>> comment why this is needed?
>>
>
> commented as suggested
I was unclear in my message: Of course there are some submodules that
are being fetched; why should we fetch them in the first place? From
a cursory glance, they seem required to do stuff such as running the
tests, which in this iteration of the patch are not being run.
FWIW, leaving out the `recursive? #t' still allows me to build
tesseract-ocr: could you try and see if it makes a difference in your
use of tesseract?
>> > (inputs
>> > - `(("leptonica" ,leptonica)))
>> > + `( ("cairo" ,cairo)
>> > + ("icu" ,icu4c)
>> > + ("leptonica" ,leptonica)
>> > + ("pango" ,pango)))
I just built the package: no references are made to cairo, icu4c and
pango, and tesseract seems to build fine without them: is there a
specific reason why these were added to the inputs?
>> > + (native-inputs
>> > + `(("autoconf" ,autoconf)
>> > + ("autoconf-archive" ,autoconf-archive)
>> > + ("automake" ,automake)
>> > + ("googletest" ,googletest)
>> > + ("libtool" ,libtool)
>> > + ("pkg-config" ,pkg-config)))
>> > (arguments
>> > '(#:configure-flags
>> > (let ((leptonica (assoc-ref %build-inputs "leptonica")))
>> > - (list (string-append "LIBLEPT_HEADERSDIR=" leptonica "/include")))))
>> > + (list (string-append "LIBLEPT_HEADERSDIR=" leptonica "/include")))
>> > + ;; some test, applybox_test fails to build
>> > + #:tests? #f))
>> 2 nits: Is it possible to patch or disable only the failing tests?
>
> tests failing to build probably due to some issue with parallel
> builds; did not dig into it as probably will take much time; will be
> TODO if time allows)
I'll defer to someone with more experience with tesseract, as I have no
experience to speak of on whether this leads to us having a (subtly)
broken package.
Adding the following arguments might help to validate your assumption:
`#:make-flags (list "-j" "1")'.
Thanks,
- Jelle
next prev parent reply other threads:[~2021-02-09 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 6:32 [bug#46377] [PATCH] gnu: tesseract-ocr: update to 4.1.1 Andy Tai
2021-02-08 6:42 ` [bug#46376] " Andy Tai
[not found] ` <handler.46376.B.161276666727875.ack@debbugs.gnu.org>
2021-02-08 6:51 ` [bug#46376] [PATCH] gnu: tesseract-ocr: update to 4.1.1) Andy Tai
2021-02-08 21:36 ` Jelle Licht
2021-02-08 23:14 ` Andy Tai
2021-02-09 11:56 ` Jelle Licht [this message]
2021-02-09 16:22 ` Andy Tai
2021-02-09 22:43 ` Jelle Licht
2021-02-09 22:53 ` Andy Tai
2021-02-10 7:52 ` Andy Tai
2021-02-11 0:00 ` Andy Tai
2021-02-11 10:48 ` Jelle Licht
2021-02-11 18:34 ` Andy Tai
2021-02-13 14:34 ` bug#46376: " Jelle Licht
2021-02-13 20:37 ` [bug#46376] " Andy Tai
[not found] ` <handler.46377.B.161277624811801.ack@debbugs.gnu.org>
2021-02-08 17:53 ` [bug#46377] Acknowledgement ([PATCH] " Andy Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867dnhpi85.fsf@posteo.net \
--to=jlicht@posteo.net \
--cc=46376@debbugs.gnu.org \
--cc=atai@atai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).