From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id DGceMELRIWDKRgAA0tVLHw (envelope-from ) for ; Tue, 09 Feb 2021 00:03:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cGp8K0LRIWBjLQAAbx9fmQ (envelope-from ) for ; Tue, 09 Feb 2021 00:03:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 52BC89403E8 for ; Tue, 9 Feb 2021 00:03:14 +0000 (UTC) Received: from localhost ([::1]:57642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9GUr-0005hq-BN for larch@yhetil.org; Mon, 08 Feb 2021 19:03:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9FAQ-0002SB-16 for guix-patches@gnu.org; Mon, 08 Feb 2021 17:38:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9FAP-0005Nk-Pg for guix-patches@gnu.org; Mon, 08 Feb 2021 17:38:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9FAP-0002ER-MO for guix-patches@gnu.org; Mon, 08 Feb 2021 17:38:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46376] [PATCH] gnu: tesseract-ocr: update to 4.1.1) Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Feb 2021 22:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46376 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai , 46376@debbugs.gnu.org Received: via spool by 46376-submit@debbugs.gnu.org id=B46376.16128238288517 (code B ref 46376); Mon, 08 Feb 2021 22:38:01 +0000 Received: (at 46376) by debbugs.gnu.org; 8 Feb 2021 22:37:08 +0000 Received: from localhost ([127.0.0.1]:52092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9F9W-0002DI-Vb for submit@debbugs.gnu.org; Mon, 08 Feb 2021 17:37:07 -0500 Received: from mail1.fsfe.org ([217.69.89.151]:51130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9ED8-000797-N5 for 46376@debbugs.gnu.org; Mon, 08 Feb 2021 16:36:47 -0500 From: Jelle Licht In-Reply-To: References: Date: Mon, 08 Feb 2021 22:36:43 +0100 Message-ID: <86a6sep7h0.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Approved-At: Mon, 08 Feb 2021 17:37:05 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Mon, 08 Feb 2021 17:53:00 -0500 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.26 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (strict), No valid DKIM" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 52BC89403E8 X-Spam-Score: -2.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7o1oIx1LTrin Hello Andy, Thanks for working on this package! I was not able to cleanly apply any of the patches, but that problem might be on my end though. Something did seem to go wrong though, as I notice three patches that do the same (from a quick glance). I have some nitpicks, some of them more serious than others; Andy Tai writes: > * gnu/packages/ocr.scm (tesseract-ocr): update to 4.1.1 ^ This is usually capitalised. > [snip] > (define-public tesseract-ocr > + ;; some useful commits beyond last official stable release in release branch > + (let ((commit "97079fa353557af6df86fd20b5d2e0dff5d8d5df")) > (package > (name "tesseract-ocr") > - (version "3.04.01") > + (version "4.1.1") ^ Since we are not _actually_ using version 4.1.1, but a later commit, you could use `(git-version "4.1.1" revision commit)' here instead > (source > (origin > (method git-fetch) > (uri (git-reference > (url "https://github.com/tesseract-ocr/tesseract") > - (commit version))) > - (file-name (git-file-name name version)) > + (commit commit) > + ;; Fetch git submodules > + (recursive? #t))) Instead of stating what the code does, would you consider adding a comment why this is needed? > + (file-name (string-append name "-" version "-" commit "-checkout")) ^ You can use `(git-file-name name version)' here. > (sha256 > - (base32 "0h1x4z1h86n2gwknd0wck6gykkp99bmm02lg4a47a698g4az6ybv")))) > + (base32 "0axwla82fpzp86lc553wp3hk0fz5dylw4as0jbf4hkqcyajlbzp4")))) > (build-system gnu-build-system) > (inputs > - `(("leptonica" ,leptonica))) > + `( ("cairo" ,cairo) > + ("icu" ,icu4c) > + ("leptonica" ,leptonica) > + ("pango" ,pango))) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("autoconf-archive" ,autoconf-archive) > + ("automake" ,automake) > + ("googletest" ,googletest) > + ("libtool" ,libtool) > + ("pkg-config" ,pkg-config))) > (arguments > '(#:configure-flags > (let ((leptonica (assoc-ref %build-inputs "leptonica"))) > - (list (string-append "LIBLEPT_HEADERSDIR=" leptonica "/include"))))) > + (list (string-append "LIBLEPT_HEADERSDIR=" leptonica "/include"))) > + ;; some test, applybox_test fails to build > + #:tests? #f)) 2 nits: Is it possible to patch or disable only the failing tests? Is there a reason googletest is added if testing is subsequently disabled? Thanks, - Jelle