unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 66359@debbugs.gnu.org
Subject: [bug#66359] meaning of %something? (was Re: [bug#66359] [PATCH] gnu: curl: Update to 8.3.0.)
Date: Mon, 09 Oct 2023 18:57:01 +0200	[thread overview]
Message-ID: <6f96ceb637ecb88eefbf851f7dbd1b82811b65d3.camel@gmail.com> (raw)
In-Reply-To: <87pm1ot1ps.fsf@gmail.com>

Am Montag, dem 09.10.2023 um 14:33 +0200 schrieb Simon Tournier:
> Hi Liliana,
> 
> On Fri, 06 Oct 2023 at 11:55, Liliana Marie Prikler
> <liliana.prikler@gmail.com> wrote:
> 
> > > Well, %something is usually for "global" parameters.  At least,
> > > that the convention with Guix.  Therefore, I would suggest to not
> > > use it in order to avoid confusion.
> > 
> > As far as I understand %something means "implementation detail" and
> > *something* means global, important something, but I might be
> > mistaken about that.
> 
> For your information, what the Cookbook says about %something:
> 
>         The percentage % is typically used for read-only global
>         variables in the build stage. Note that it is merely a
>         convention, like _ in C. Scheme treats % exactly the same as
> any
>         other letter.
> 
>        
> https://guix.gnu.org/cookbook/en/guix-cookbook.html#A-Scheme-Crash-Course
> 
> I think your change using ’%version’ in some let-binding is not
> consistent with the rest.
I don't think my usage of the percent style changes the meaning of
"typically".  Our implementation details are typically, but not
exclusively, global variables in the build stage.

> My aim with this message is only to communicate on some practises.
> Maybe something should be raised on guix-devel.  Well, if you and I,
> both spending some time working on Guix do not have the same
> understanding for %something, then it means something is poorly
> documented somewhere. :-)
> 
> WDYT about adding a paragraph about %something under,
> 
>     https://guix.gnu.org/manual/devel/en/guix.html#Coding-Style
> 
> ?
I'll consider it, but perhaps explaining this within the same cookbook
entry might be a better idea.  Regardless of the outcome in Guix Devel,
I don't think that constraining variable names *too* hard is helpful,
though.

Cheers




      reply	other threads:[~2023-10-09 17:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05  6:11 [bug#66359] [PATCH] gnu: curl: Update to 8.3.0 Liliana Marie Prikler
2023-10-05  7:19 ` Efraim Flashner
2023-10-05  7:44   ` bug#66359: " Liliana Marie Prikler
2023-10-05 16:26 ` [bug#66359] " Simon Tournier
2023-10-06  8:54   ` Liliana Marie Prikler
2023-10-06  9:09     ` Simon Tournier
2023-10-06  9:55       ` Liliana Marie Prikler
2023-10-06 10:15         ` Simon Tournier
2023-10-09 12:33         ` [bug#66359] meaning of %something? (was Re: [bug#66359] [PATCH] gnu: curl: Update to 8.3.0.) Simon Tournier
2023-10-09 16:57           ` Liliana Marie Prikler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f96ceb637ecb88eefbf851f7dbd1b82811b65d3.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=66359@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).