* [bug#44470] [PATCH] gnu: Added emacs-solidity.
@ 2020-11-05 15:20 Martin Becze
2020-11-05 17:07 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Martin Becze @ 2020-11-05 15:20 UTC (permalink / raw)
To: 44470; +Cc: Martin Becze
* gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2043ce19df..5a085cfd89 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25281,3 +25281,28 @@ the TypeScript implementation.")
(description "This package provides an Emacs client for the Rocket.chat
service.")
(license license:expat))))
+
+(define-public emacs-solidity
+ ;; No release.
+ (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
+ (package
+ (name "emacs-solidity")
+ (version (git-version "0.1.10" "1" commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ethereum/emacs-solidity")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-company" ,emacs-company)
+ ("emacs-flycheck" ,emacs-flycheck)))
+ (home-page "https://github.com/ethereum/emacs-solidity")
+ (synopsis "Major mode for writing Solidity code")
+ (description "A simple language mode for the Solidity language. It is a
+constant work in progress as the language itself also progresses.")
+ (license license:gpl3+))))
--
2.29.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#44470] [PATCH] gnu: Added emacs-solidity.
2020-11-05 15:20 [bug#44470] [PATCH] gnu: Added emacs-solidity Martin Becze
@ 2020-11-05 17:07 ` Nicolas Goaziou
2020-11-05 19:50 ` Martin Becze
2020-11-05 19:52 ` Martin Becze
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2020-11-05 17:07 UTC (permalink / raw)
To: Martin Becze; +Cc: 44470
Hello,
Martin Becze <mjbecze@riseup.net> writes:
> * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
Thank you.
> + ;; No release.
> + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
Is there any reason to use this particular instead of
e91c36cc20a2e683b930712a7f9c0ab28451b347, which is the exact "0.1.10"
release? If so, please mention it in the comment above.
> + (package
> + (name "emacs-solidity")
> + (version (git-version "0.1.10" "1" commit))
If we use the commit above, `version' can simply become "0.1.10".
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/ethereum/emacs-solidity")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-company" ,emacs-company)
> + ("emacs-flycheck" ,emacs-flycheck)))
> + (home-page "https://github.com/ethereum/emacs-solidity")
> + (synopsis "Major mode for writing Solidity code")
> + (description "A simple language mode for the Solidity language. It is a
> +constant work in progress as the language itself also progresses.")
The first sentence should be "complete", i.e., with a subject and
a verb.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#44470] [PATCH] gnu: Added emacs-solidity.
2020-11-05 17:07 ` Nicolas Goaziou
@ 2020-11-05 19:50 ` Martin Becze
2020-11-05 19:52 ` Martin Becze
1 sibling, 0 replies; 5+ messages in thread
From: Martin Becze @ 2020-11-05 19:50 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 44470
[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]
Thank you for the review Nocolas. I choose the latest commit because it
fixes some spacing issues and has support for more keywords. While not
absolutely necessary the release cycle seems to be very slow and this is
the version that is on Melpa. Attachedd is an updated patch.
On 11/5/20 11:07 AM, Nicolas Goaziou wrote:
> Hello,
>
> Martin Becze <mjbecze@riseup.net> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
>
> Thank you.
>
>> + ;; No release.
>> + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
>
> Is there any reason to use this particular instead of
> e91c36cc20a2e683b930712a7f9c0ab28451b347, which is the exact "0.1.10"
> release? If so, please mention it in the comment above.
>
>> + (package
>> + (name "emacs-solidity")
>> + (version (git-version "0.1.10" "1" commit))
>
> If we use the commit above, `version' can simply become "0.1.10".
>
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/ethereum/emacs-solidity")
>> + (commit commit)))
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
>> + (build-system emacs-build-system)
>> + (propagated-inputs
>> + `(("emacs-company" ,emacs-company)
>> + ("emacs-flycheck" ,emacs-flycheck)))
>> + (home-page "https://github.com/ethereum/emacs-solidity")
>> + (synopsis "Major mode for writing Solidity code")
>> + (description "A simple language mode for the Solidity language. It is a
>> +constant work in progress as the language itself also progresses.")
>
> The first sentence should be "complete", i.e., with a subject and
> a verb.
>
> Could you send an updated patch?
>
> Regards,
>
[-- Attachment #2: v1-0001-gnu-Added-emacs-solidity.patch --]
[-- Type: text/x-patch, Size: 1780 bytes --]
From 1216fc95cc9b480375e8dc344510f1a24f7b2c84 Mon Sep 17 00:00:00 2001
From: Martin Becze <mjbecze@riseup.net>
Date: Thu, 5 Nov 2020 09:18:01 -0600
Subject: [PATCH v1] gnu: Added emacs-solidity.
* gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2043ce19df..78cf2e31c3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25281,3 +25281,28 @@ the TypeScript implementation.")
(description "This package provides an Emacs client for the Rocket.chat
service.")
(license license:expat))))
+
+(define-public emacs-solidity
+ ;; This commit fixes a spacing issue and adds new keywords
+ (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
+ (package
+ (name "emacs-solidity")
+ (version (git-version "0.1.10" "1" commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ethereum/emacs-solidity")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-company" ,emacs-company)
+ ("emacs-flycheck" ,emacs-flycheck)))
+ (home-page "https://github.com/ethereum/emacs-solidity")
+ (synopsis "Major mode for writing Solidity code")
+ (description "This is a simple language mode for the Solidity language.
+It is a constant work in progress as the language itself also progresses.")
+ (license license:gpl3+))))
--
2.29.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#44470] [PATCH] gnu: Added emacs-solidity.
2020-11-05 17:07 ` Nicolas Goaziou
2020-11-05 19:50 ` Martin Becze
@ 2020-11-05 19:52 ` Martin Becze
2020-11-05 22:29 ` bug#44470: " Nicolas Goaziou
1 sibling, 1 reply; 5+ messages in thread
From: Martin Becze @ 2020-11-05 19:52 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 44470
[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]
> If we use the commit above, `version' can simply become "0.1.10".
Opps sorry missed this comment. Attached is a patch that fixes that too.
On 11/5/20 11:07 AM, Nicolas Goaziou wrote:
> Hello,
>
> Martin Becze <mjbecze@riseup.net> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
>
> Thank you.
>
>> + ;; No release.
>> + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
>
> Is there any reason to use this particular instead of
> e91c36cc20a2e683b930712a7f9c0ab28451b347, which is the exact "0.1.10"
> release? If so, please mention it in the comment above.
>
>> + (package
>> + (name "emacs-solidity")
>> + (version (git-version "0.1.10" "1" commit))
>
> If we use the commit above, `version' can simply become "0.1.10".
>
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/ethereum/emacs-solidity")
>> + (commit commit)))
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
>> + (build-system emacs-build-system)
>> + (propagated-inputs
>> + `(("emacs-company" ,emacs-company)
>> + ("emacs-flycheck" ,emacs-flycheck)))
>> + (home-page "https://github.com/ethereum/emacs-solidity")
>> + (synopsis "Major mode for writing Solidity code")
>> + (description "A simple language mode for the Solidity language. It is a
>> +constant work in progress as the language itself also progresses.")
>
> The first sentence should be "complete", i.e., with a subject and
> a verb.
>
> Could you send an updated patch?
>
> Regards,
>
[-- Attachment #2: v3-0001-gnu-Added-emacs-solidity.patch --]
[-- Type: text/x-patch, Size: 1755 bytes --]
From c8f9487a07700f5ed17b2ddd726e30c4bf21acec Mon Sep 17 00:00:00 2001
From: Martin Becze <mjbecze@riseup.net>
Date: Thu, 5 Nov 2020 09:18:01 -0600
Subject: [PATCH v3] gnu: Added emacs-solidity.
* gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2043ce19df..846429fbdf 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25281,3 +25281,28 @@ the TypeScript implementation.")
(description "This package provides an Emacs client for the Rocket.chat
service.")
(license license:expat))))
+
+(define-public emacs-solidity
+ ;; This commit fixes a spacing issue and adds new keywords
+ (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
+ (package
+ (name "emacs-solidity")
+ (version "0.1.10")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ethereum/emacs-solidity")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-company" ,emacs-company)
+ ("emacs-flycheck" ,emacs-flycheck)))
+ (home-page "https://github.com/ethereum/emacs-solidity")
+ (synopsis "Major mode for writing Solidity code")
+ (description "This is a simple language mode for the Solidity language.
+It is a constant work in progress as the language itself also progresses.")
+ (license license:gpl3+))))
--
2.29.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#44470: [PATCH] gnu: Added emacs-solidity.
2020-11-05 19:52 ` Martin Becze
@ 2020-11-05 22:29 ` Nicolas Goaziou
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2020-11-05 22:29 UTC (permalink / raw)
To: Martin Becze; +Cc: 44470-done
Hello,
Martin Becze <mjbecze@riseup.net> writes:
> Opps sorry missed this comment. Attached is a patch that fixes that
> too.
Actually, it is not necessary since you kept latest commit.
Patch applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-05 22:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-05 15:20 [bug#44470] [PATCH] gnu: Added emacs-solidity Martin Becze
2020-11-05 17:07 ` Nicolas Goaziou
2020-11-05 19:50 ` Martin Becze
2020-11-05 19:52 ` Martin Becze
2020-11-05 22:29 ` bug#44470: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).