From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Martin Becze <mjbecze@riseup.net>
Cc: 44470@debbugs.gnu.org
Subject: [bug#44470] [PATCH] gnu: Added emacs-solidity.
Date: Thu, 05 Nov 2020 18:07:44 +0100 [thread overview]
Message-ID: <87zh3vlokf.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20201105152052.6017-1-mjbecze@riseup.net> (Martin Becze's message of "Thu, 5 Nov 2020 09:20:52 -0600")
Hello,
Martin Becze <mjbecze@riseup.net> writes:
> * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
Thank you.
> + ;; No release.
> + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
Is there any reason to use this particular instead of
e91c36cc20a2e683b930712a7f9c0ab28451b347, which is the exact "0.1.10"
release? If so, please mention it in the comment above.
> + (package
> + (name "emacs-solidity")
> + (version (git-version "0.1.10" "1" commit))
If we use the commit above, `version' can simply become "0.1.10".
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/ethereum/emacs-solidity")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-company" ,emacs-company)
> + ("emacs-flycheck" ,emacs-flycheck)))
> + (home-page "https://github.com/ethereum/emacs-solidity")
> + (synopsis "Major mode for writing Solidity code")
> + (description "A simple language mode for the Solidity language. It is a
> +constant work in progress as the language itself also progresses.")
The first sentence should be "complete", i.e., with a subject and
a verb.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-11-05 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:20 [bug#44470] [PATCH] gnu: Added emacs-solidity Martin Becze
2020-11-05 17:07 ` Nicolas Goaziou [this message]
2020-11-05 19:50 ` Martin Becze
2020-11-05 19:52 ` Martin Becze
2020-11-05 22:29 ` bug#44470: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh3vlokf.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=44470@debbugs.gnu.org \
--cc=mjbecze@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).