[bug#37642] [PATCH] gnu: Add filters

[Jesse Gibbons <jgibbons2357@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2156 bytes --]

On Wed, 2019-10-09 at 15:14 +0200, Tobias Geerinckx-Rice wrote:
> Jesse,
> 
> Jesse Gibbons 写道：
> > That review was a bit of a mess. Let's see if I can rephrase 
> > what you want,
> > in a human-friendly format (no emacs involved):
> 
> Yes, I'm so sorry.  It looked fine while writing; I'm not actually 
> on crack.
emacs might have been.

> > Use a patch instead or move this to the source's snippet so 
> > kenny is removed
> > from the raw source.
> 
> A patch would contain a ‘negative’ verbatim copy of the non-free 
> code so isn't an option here.
> 
Moved it to source's snippet.
> > > +         #:tests? #f))
> > clarify we have no tests suite
> 
> Yep.  Ideally that comment would be redundant because we'd never 
> flat-out disable tests in packages that have them, but we do.
> 
rednotebook's test suite is disabled because it fails, but the program
itself works fine. There's a TODO note there to fix the tests.

Added comment.

> > > +The GNU project hosts a similar collection of filters, the GNU
> > > talkfilters.  Due
> > > +to copyright concerns and difficulty in communication between
> > > maintainers, these
> > > +collections have not been merged.")
> > You want me to remove this.
> > I think it's appropriate to say something about gnu talkfilters 
> > and note
> > that this is not the same package, given that filters and 
> > talkfilters
> > packages are often confused with each other on the internet,
> 
> OK.  I didn't know they were often confused.  Would it make sense 
> to add it to GNU's, too?
> 
> > but I will remove the last sentence.
> 
> Great.  It's the one that bothered me.
> 
Sentence removed
> >  If the comments go beyond 80 characters I will move the 
> >  comments above the license.
> 
> For such whole-line comments you *would* use ‘;;’, start with a 
> capital letter, and end with a full stop…
> 
I was able to fit the comments after a line.
> > Am I missing anything?
> 
- Cleaned up package descriptions. Only one takes up more than a line now,
and they focus more on behavior.
- Changed "80's" to "1980's"
- Fixed various typos

New patch is attached.
> 
> Kind regards,
> 
> T G-R


[-- Attachment #2: 0001-gnu-add-filters.patch --]
[-- Type: text/x-patch, Size: 4888 bytes --]

From 50325522d953f06325543efb61f1fa26cb98340f Mon Sep 17 00:00:00 2001
From: Jesse Gibbons <jgibbons2357+guix@gmail.com>
Date: Wed, 9 Oct 2019 22:29:16 -0600
Subject: [PATCH] gnu: add filters.

    * gnu/packages/toys.scm (filters): New variable.
---
 gnu/packages/toys.scm | 93 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 93 insertions(+)

diff --git a/gnu/packages/toys.scm b/gnu/packages/toys.scm
index 87706d2277..62c07eded7 100644
--- a/gnu/packages/toys.scm
+++ b/gnu/packages/toys.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -17,7 +18,10 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages toys)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages perl)
   #:use-module (guix build-system gnu)
   #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
@@ -64,3 +68,92 @@ on the text terminal.  It serves no useful purpose but to discourage mistakenly
 typing @command{sl} instead of @command{ls}.")
     (license (license:non-copyleft "file://LICENSE"
                                    "See LICENSE in the distribution."))))
+
+(define-public filters
+  (let
+      ((version "2.55")
+       (commit "c5c291916b52ed9e6418448a8eee30475fb9adcf"))
+    (package
+      (name "filters")
+      (version "2.55")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://git.joeyh.name/filters")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1gaigpda1w9wxfh8an3sam1hpacc1bhxl696w4yj0vzhc6izqvxs"))
+	 (modules '((guix build utils)))
+	 (snippet '(begin
+		     ;; kenny is under nonfree Artistic License (Perl) 1.0.
+		     (delete-file "kenny")
+	    (substitute* "Makefile"
+			 (("kenny")
+			  ""))))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+			(delete 'configure)
+			(add-after 'unpack 'fix-install-directories
+				   (lambda _
+				     (substitute* "Makefile"
+						  (("/usr/games")
+						   "/bin/")
+						  (("/usr/share/")
+						   "/share/"))
+				     #t)))
+         #:make-flags (list "CC=gcc" (string-append "DESTDIR=" %output))
+         #:tests? #f)) ; no test suite
+      (native-inputs
+       `(("bison" ,bison)
+         ("flex" ,flex)))
+      (inputs
+       `(("perl" ,perl)))
+      (home-page "https://joeyh.name/code/filters/")
+      (synopsis "Various amusing text filters")
+      (description "The filters collection harks back to the late 1980's, when
+various text filters were written to munge written language in amusing ways.
+The earliest and best known were legends such as the Swiedish Chef filter and
+B1FF.
+
+The current filters package contains the following filters:
+@enumerate
+@item b1ff - The B1FF filter
+@item censor - CDA-ize text
+@item chef - convert English to Mock Swedish.
+@item cockney - Cockney English
+@item eleet - K3wl hacker slang
+@item fanboy - Echo instances of the words fans use. (supports custom fandoms)
+@item fudd - Elmer Fudd
+@item jethro - Hillbilly text filter
+@item jibberish - A random selection of the filters.
+@item jive - Jive English
+@item ken - English into Cockney.
+@item kraut - Generates text with a bad German accent.
+@item ky00te - This program places a very cute accent on any text file.
+@item LOLCAT - as seen in internet gifs everywhere.
+@item nethackify - Wiped out text like what can be found in nethack.
+@item newspeak - A-la-1984
+@item nyc - Brooklyn English
+@item pirate - Talk like a pirate.
+@item rasterman - Makes text look like it came from the keyboard of Carsten
+Haitzler.
+@item scottish - Fake scottish (dwarven) accent filter.
+@item scramble - Scramble the \"inner\" letters of each word in the input.
+@item spammer - Turns honest text into something liable to be flagged as spam.
+@item studly - Studly caps.
+@item uniencode - Use glorious unicode to the fullest possible extent.
+@item upside-down - Flips the text upside down.
+@end enumerate
+The GNU project hosts a similar collection of filters, the GNU talkfilters.")
+      (license ;see debian/copyright
+       (list license:gpl2+         ; most of the filters
+	     license:gpl2          ; rasterman, ky00te.dir/* nethackify, pirate
+	     license:gpl3+         ; scramble, scottish
+	     license:public-domain ; jethro, kraut, ken, studly
+	     license:gpl1+         ; cockney, jive, nyc only say "gpl"
+	     license:expat)))))    ; newspeak
-- 
2.23.0