From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36432) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIQG8-0007QJ-3z for guix-patches@gnu.org; Thu, 10 Oct 2019 00:41:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIQG6-0000bF-FK for guix-patches@gnu.org; Thu, 10 Oct 2019 00:41:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46104) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIQG6-0000bB-7T for guix-patches@gnu.org; Thu, 10 Oct 2019 00:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIQG6-0002pC-25 for guix-patches@gnu.org; Thu, 10 Oct 2019 00:41:02 -0400 Subject: [bug#37642] [PATCH] gnu: Add filters Resent-Message-ID: Message-ID: <48d0e5df510f6551be63c9ec4545f06bdf7ffc5d.camel@gmail.com> From: Jesse Gibbons In-Reply-To: <87lftu9i2b.fsf@nckx> References: <6f4a21523a30dcf3e3045aad994d8958c78a7b72.camel@gmail.com> <87lftv1dwb.fsf@nckx> <14cbe887a25f732826a1e920e2d0140dbce51893.camel@gmail.com> <87lftu9i2b.fsf@nckx> Content-Type: multipart/mixed; boundary="=-KqVmMhxSt6iTGAnSRthv" Date: Wed, 09 Oct 2019 22:40:39 -0600 MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 37642@debbugs.gnu.org --=-KqVmMhxSt6iTGAnSRthv Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Wed, 2019-10-09 at 15:14 +0200, Tobias Geerinckx-Rice wrote: > Jesse, > > Jesse Gibbons 写道： > > That review was a bit of a mess. Let's see if I can rephrase > > what you want, > > in a human-friendly format (no emacs involved): > > Yes, I'm so sorry. It looked fine while writing; I'm not actually > on crack. emacs might have been. > > Use a patch instead or move this to the source's snippet so > > kenny is removed > > from the raw source. > > A patch would contain a ‘negative’ verbatim copy of the non-free > code so isn't an option here. > Moved it to source's snippet. > > > + #:tests? #f)) > > clarify we have no tests suite > > Yep. Ideally that comment would be redundant because we'd never > flat-out disable tests in packages that have them, but we do. > rednotebook's test suite is disabled because it fails, but the program itself works fine. There's a TODO note there to fix the tests. Added comment. > > > +The GNU project hosts a similar collection of filters, the GNU > > > talkfilters. Due > > > +to copyright concerns and difficulty in communication between > > > maintainers, these > > > +collections have not been merged.") > > You want me to remove this. > > I think it's appropriate to say something about gnu talkfilters > > and note > > that this is not the same package, given that filters and > > talkfilters > > packages are often confused with each other on the internet, > > OK. I didn't know they were often confused. Would it make sense > to add it to GNU's, too? > > > but I will remove the last sentence. > > Great. It's the one that bothered me. > Sentence removed > > If the comments go beyond 80 characters I will move the > > comments above the license. > > For such whole-line comments you *would* use ‘;;’, start with a > capital letter, and end with a full stop… > I was able to fit the comments after a line. > > Am I missing anything? > - Cleaned up package descriptions. Only one takes up more than a line now, and they focus more on behavior. - Changed "80's" to "1980's" - Fixed various typos New patch is attached. > > Kind regards, > > T G-R --=-KqVmMhxSt6iTGAnSRthv Content-Disposition: attachment; filename="0001-gnu-add-filters.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-add-filters.patch"; charset="UTF-8" RnJvbSA1MDMyNTUyMmQ5NTNmMDYzMjU1NDNlZmI2MWYxZmEyNmNiOTgzNDBmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXNzZSBHaWJib25zIDxqZ2liYm9uczIzNTcrZ3VpeEBnbWFp bC5jb20+CkRhdGU6IFdlZCwgOSBPY3QgMjAxOSAyMjoyOToxNiAtMDYwMApTdWJqZWN0OiBbUEFU Q0hdIGdudTogYWRkIGZpbHRlcnMuCgogICAgKiBnbnUvcGFja2FnZXMvdG95cy5zY20gKGZpbHRl cnMpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL3RveXMuc2NtIHwgOTMgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDkz IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvdG95cy5zY20gYi9nbnUv cGFja2FnZXMvdG95cy5zY20KaW5kZXggODc3MDZkMjI3Ny4uNjJjMDdlZGVkNyAxMDA2NDQKLS0t IGEvZ251L3BhY2thZ2VzL3RveXMuc2NtCisrKyBiL2dudS9wYWNrYWdlcy90b3lzLnNjbQpAQCAt MSw1ICsxLDYgQEAKIDs7OyBHTlUgR3VpeCAtLS0gRnVuY3Rpb25hbCBwYWNrYWdlIG1hbmFnZW1l bnQgZm9yIEdOVQogOzs7IENvcHlyaWdodCDCqSAyMDE3LCAyMDE4IFRvYmlhcyBHZWVyaW5ja3gt UmljZSA8bWVAdG9iaWFzLmdyPgorOzs7IENvcHlyaWdodCDCqSAyMDE5IEplc3NlIEdpYmJvbnMg PGpnaWJib25zMjM1NytndWl4QGdtYWlsLmNvbT4KIDs7OwogOzs7IFRoaXMgZmlsZSBpcyBwYXJ0 IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0xNyw3ICsxOCwxMCBAQAogOzs7IGFsb25nIHdpdGggR05V IEd1aXguICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCiAKIChk ZWZpbmUtbW9kdWxlIChnbnUgcGFja2FnZXMgdG95cykKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFj a2FnZXMgYmlzb24pCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGZsZXgpCiAgICM6dXNl LW1vZHVsZSAoZ251IHBhY2thZ2VzIG5jdXJzZXMpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIHBlcmwpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBidWlsZC1zeXN0ZW0gZ251KQogICAjOnVz ZS1tb2R1bGUgKGd1aXggZ2l0LWRvd25sb2FkKQogICAjOnVzZS1tb2R1bGUgKChndWl4IGxpY2Vu c2VzKSAjOnByZWZpeCBsaWNlbnNlOikKQEAgLTY0LDMgKzY4LDkyIEBAIG9uIHRoZSB0ZXh0IHRl cm1pbmFsLiAgSXQgc2VydmVzIG5vIHVzZWZ1bCBwdXJwb3NlIGJ1dCB0byBkaXNjb3VyYWdlIG1p c3Rha2VubHkKIHR5cGluZyBAY29tbWFuZHtzbH0gaW5zdGVhZCBvZiBAY29tbWFuZHtsc30uIikK ICAgICAobGljZW5zZSAobGljZW5zZTpub24tY29weWxlZnQgImZpbGU6Ly9MSUNFTlNFIgogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiU2VlIExJQ0VOU0UgaW4gdGhlIGRpc3Ry aWJ1dGlvbi4iKSkpKQorCisoZGVmaW5lLXB1YmxpYyBmaWx0ZXJzCisgIChsZXQKKyAgICAgICgo dmVyc2lvbiAiMi41NSIpCisgICAgICAgKGNvbW1pdCAiYzVjMjkxOTE2YjUyZWQ5ZTY0MTg0NDhh OGVlZTMwNDc1ZmI5YWRjZiIpKQorICAgIChwYWNrYWdlCisgICAgICAobmFtZSAiZmlsdGVycyIp CisgICAgICAodmVyc2lvbiAiMi41NSIpCisgICAgICAoc291cmNlCisgICAgICAgKG9yaWdpbgor ICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNl CisgICAgICAgICAgICAgICAodXJsICJodHRwczovL2dpdC5qb2V5aC5uYW1lL2ZpbHRlcnMiKQor ICAgICAgICAgICAgICAgKGNvbW1pdCBjb21taXQpKSkKKyAgICAgICAgIChmaWxlLW5hbWUgKGdp dC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAgICAgICAgIChzaGEyNTYKKyAgICAgICAgICAo YmFzZTMyCisgICAgICAgICAgICIxZ2FpZ3BkYTF3OXd4Zmg4YW4zc2FtMWhwYWNjMWJoeGw2OTZ3 NHlqMHZ6aGM2aXpxdnhzIikpCisJIChtb2R1bGVzICcoKGd1aXggYnVpbGQgdXRpbHMpKSkKKwkg KHNuaXBwZXQgJyhiZWdpbgorCQkgICAgIDs7IGtlbm55IGlzIHVuZGVyIG5vbmZyZWUgQXJ0aXN0 aWMgTGljZW5zZSAoUGVybCkgMS4wLgorCQkgICAgIChkZWxldGUtZmlsZSAia2VubnkiKQorCSAg ICAoc3Vic3RpdHV0ZSogIk1ha2VmaWxlIgorCQkJICgoImtlbm55IikKKwkJCSAgIiIpKSkpKSkK KyAgICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAgIChhcmd1bWVudHMK KyAgICAgICBgKCM6cGhhc2VzCisgICAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhh c2VzCisJCQkoZGVsZXRlICdjb25maWd1cmUpCisJCQkoYWRkLWFmdGVyICd1bnBhY2sgJ2ZpeC1p bnN0YWxsLWRpcmVjdG9yaWVzCisJCQkJICAgKGxhbWJkYSBfCisJCQkJICAgICAoc3Vic3RpdHV0 ZSogIk1ha2VmaWxlIgorCQkJCQkJICAoKCIvdXNyL2dhbWVzIikKKwkJCQkJCSAgICIvYmluLyIp CisJCQkJCQkgICgoIi91c3Ivc2hhcmUvIikKKwkJCQkJCSAgICIvc2hhcmUvIikpCisJCQkJICAg ICAjdCkpKQorICAgICAgICAgIzptYWtlLWZsYWdzIChsaXN0ICJDQz1nY2MiIChzdHJpbmctYXBw ZW5kICJERVNURElSPSIgJW91dHB1dCkpCisgICAgICAgICAjOnRlc3RzPyAjZikpIDsgbm8gdGVz dCBzdWl0ZQorICAgICAgKG5hdGl2ZS1pbnB1dHMKKyAgICAgICBgKCgiYmlzb24iICxiaXNvbikK KyAgICAgICAgICgiZmxleCIgLGZsZXgpKSkKKyAgICAgIChpbnB1dHMKKyAgICAgICBgKCgicGVy bCIgLHBlcmwpKSkKKyAgICAgIChob21lLXBhZ2UgImh0dHBzOi8vam9leWgubmFtZS9jb2RlL2Zp bHRlcnMvIikKKyAgICAgIChzeW5vcHNpcyAiVmFyaW91cyBhbXVzaW5nIHRleHQgZmlsdGVycyIp CisgICAgICAoZGVzY3JpcHRpb24gIlRoZSBmaWx0ZXJzIGNvbGxlY3Rpb24gaGFya3MgYmFjayB0 byB0aGUgbGF0ZSAxOTgwJ3MsIHdoZW4KK3ZhcmlvdXMgdGV4dCBmaWx0ZXJzIHdlcmUgd3JpdHRl biB0byBtdW5nZSB3cml0dGVuIGxhbmd1YWdlIGluIGFtdXNpbmcgd2F5cy4KK1RoZSBlYXJsaWVz dCBhbmQgYmVzdCBrbm93biB3ZXJlIGxlZ2VuZHMgc3VjaCBhcyB0aGUgU3dpZWRpc2ggQ2hlZiBm aWx0ZXIgYW5kCitCMUZGLgorCitUaGUgY3VycmVudCBmaWx0ZXJzIHBhY2thZ2UgY29udGFpbnMg dGhlIGZvbGxvd2luZyBmaWx0ZXJzOgorQGVudW1lcmF0ZQorQGl0ZW0gYjFmZiAtIFRoZSBCMUZG IGZpbHRlcgorQGl0ZW0gY2Vuc29yIC0gQ0RBLWl6ZSB0ZXh0CitAaXRlbSBjaGVmIC0gY29udmVy dCBFbmdsaXNoIHRvIE1vY2sgU3dlZGlzaC4KK0BpdGVtIGNvY2tuZXkgLSBDb2NrbmV5IEVuZ2xp c2gKK0BpdGVtIGVsZWV0IC0gSzN3bCBoYWNrZXIgc2xhbmcKK0BpdGVtIGZhbmJveSAtIEVjaG8g aW5zdGFuY2VzIG9mIHRoZSB3b3JkcyBmYW5zIHVzZS4gKHN1cHBvcnRzIGN1c3RvbSBmYW5kb21z KQorQGl0ZW0gZnVkZCAtIEVsbWVyIEZ1ZGQKK0BpdGVtIGpldGhybyAtIEhpbGxiaWxseSB0ZXh0 IGZpbHRlcgorQGl0ZW0gamliYmVyaXNoIC0gQSByYW5kb20gc2VsZWN0aW9uIG9mIHRoZSBmaWx0 ZXJzLgorQGl0ZW0gaml2ZSAtIEppdmUgRW5nbGlzaAorQGl0ZW0ga2VuIC0gRW5nbGlzaCBpbnRv IENvY2tuZXkuCitAaXRlbSBrcmF1dCAtIEdlbmVyYXRlcyB0ZXh0IHdpdGggYSBiYWQgR2VybWFu IGFjY2VudC4KK0BpdGVtIGt5MDB0ZSAtIFRoaXMgcHJvZ3JhbSBwbGFjZXMgYSB2ZXJ5IGN1dGUg YWNjZW50IG9uIGFueSB0ZXh0IGZpbGUuCitAaXRlbSBMT0xDQVQgLSBhcyBzZWVuIGluIGludGVy bmV0IGdpZnMgZXZlcnl3aGVyZS4KK0BpdGVtIG5ldGhhY2tpZnkgLSBXaXBlZCBvdXQgdGV4dCBs aWtlIHdoYXQgY2FuIGJlIGZvdW5kIGluIG5ldGhhY2suCitAaXRlbSBuZXdzcGVhayAtIEEtbGEt MTk4NAorQGl0ZW0gbnljIC0gQnJvb2tseW4gRW5nbGlzaAorQGl0ZW0gcGlyYXRlIC0gVGFsayBs aWtlIGEgcGlyYXRlLgorQGl0ZW0gcmFzdGVybWFuIC0gTWFrZXMgdGV4dCBsb29rIGxpa2UgaXQg Y2FtZSBmcm9tIHRoZSBrZXlib2FyZCBvZiBDYXJzdGVuCitIYWl0emxlci4KK0BpdGVtIHNjb3R0 aXNoIC0gRmFrZSBzY290dGlzaCAoZHdhcnZlbikgYWNjZW50IGZpbHRlci4KK0BpdGVtIHNjcmFt YmxlIC0gU2NyYW1ibGUgdGhlIFwiaW5uZXJcIiBsZXR0ZXJzIG9mIGVhY2ggd29yZCBpbiB0aGUg aW5wdXQuCitAaXRlbSBzcGFtbWVyIC0gVHVybnMgaG9uZXN0IHRleHQgaW50byBzb21ldGhpbmcg bGlhYmxlIHRvIGJlIGZsYWdnZWQgYXMgc3BhbS4KK0BpdGVtIHN0dWRseSAtIFN0dWRseSBjYXBz LgorQGl0ZW0gdW5pZW5jb2RlIC0gVXNlIGdsb3Jpb3VzIHVuaWNvZGUgdG8gdGhlIGZ1bGxlc3Qg cG9zc2libGUgZXh0ZW50LgorQGl0ZW0gdXBzaWRlLWRvd24gLSBGbGlwcyB0aGUgdGV4dCB1cHNp ZGUgZG93bi4KK0BlbmQgZW51bWVyYXRlCitUaGUgR05VIHByb2plY3QgaG9zdHMgYSBzaW1pbGFy IGNvbGxlY3Rpb24gb2YgZmlsdGVycywgdGhlIEdOVSB0YWxrZmlsdGVycy4iKQorICAgICAgKGxp Y2Vuc2UgO3NlZSBkZWJpYW4vY29weXJpZ2h0CisgICAgICAgKGxpc3QgbGljZW5zZTpncGwyKyAg ICAgICAgIDsgbW9zdCBvZiB0aGUgZmlsdGVycworCSAgICAgbGljZW5zZTpncGwyICAgICAgICAg IDsgcmFzdGVybWFuLCBreTAwdGUuZGlyLyogbmV0aGFja2lmeSwgcGlyYXRlCisJICAgICBsaWNl bnNlOmdwbDMrICAgICAgICAgOyBzY3JhbWJsZSwgc2NvdHRpc2gKKwkgICAgIGxpY2Vuc2U6cHVi bGljLWRvbWFpbiA7IGpldGhybywga3JhdXQsIGtlbiwgc3R1ZGx5CisJICAgICBsaWNlbnNlOmdw bDErICAgICAgICAgOyBjb2NrbmV5LCBqaXZlLCBueWMgb25seSBzYXkgImdwbCIKKwkgICAgIGxp Y2Vuc2U6ZXhwYXQpKSkpKSAgICA7IG5ld3NwZWFrCi0tIAoyLjIzLjAKCg== --=-KqVmMhxSt6iTGAnSRthv--