From: Jesse Gibbons <jgibbons2357@gmail.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 37642@debbugs.gnu.org
Subject: [bug#37642] [PATCH] gnu: Add filters
Date: Mon, 21 Oct 2019 12:43:10 -0600 [thread overview]
Message-ID: <2128be8b1e1810a47cf64a5a98288441709ae1a5.camel@gmail.com> (raw)
In-Reply-To: <48d0e5df510f6551be63c9ec4545f06bdf7ffc5d.camel@gmail.com>
On Wed, 2019-10-09 at 22:40 -0600, Jesse Gibbons wrote:
> On Wed, 2019-10-09 at 15:14 +0200, Tobias Geerinckx-Rice wrote:
> > Jesse,
> >
> > Jesse Gibbons 写道:
> > > That review was a bit of a mess. Let's see if I can rephrase
> > > what you want,
> > > in a human-friendly format (no emacs involved):
> >
> > Yes, I'm so sorry. It looked fine while writing; I'm not actually
> > on crack.
> emacs might have been.
>
> > > Use a patch instead or move this to the source's snippet so
> > > kenny is removed
> > > from the raw source.
> >
> > A patch would contain a ‘negative’ verbatim copy of the non-free
> > code so isn't an option here.
> >
> Moved it to source's snippet.
> > > > + #:tests? #f))
> > > clarify we have no tests suite
> >
> > Yep. Ideally that comment would be redundant because we'd never
> > flat-out disable tests in packages that have them, but we do.
> >
> rednotebook's test suite is disabled because it fails, but the program
> itself works fine. There's a TODO note there to fix the tests.
>
> Added comment.
>
> > > > +The GNU project hosts a similar collection of filters, the GNU
> > > > talkfilters. Due
> > > > +to copyright concerns and difficulty in communication between
> > > > maintainers, these
> > > > +collections have not been merged.")
> > > You want me to remove this.
> > > I think it's appropriate to say something about gnu talkfilters
> > > and note
> > > that this is not the same package, given that filters and
> > > talkfilters
> > > packages are often confused with each other on the internet,
> >
> > OK. I didn't know they were often confused. Would it make sense
> > to add it to GNU's, too?
> >
> > > but I will remove the last sentence.
> >
> > Great. It's the one that bothered me.
> >
> Sentence removed
> > > If the comments go beyond 80 characters I will move the
> > > comments above the license.
> >
> > For such whole-line comments you *would* use ‘;;’, start with a
> > capital letter, and end with a full stop…
> >
> I was able to fit the comments after a line.
> > > Am I missing anything?
> - Cleaned up package descriptions. Only one takes up more than a line now,
> and they focus more on behavior.
> - Changed "80's" to "1980's"
> - Fixed various typos
>
> New patch is attached.
> > Kind regards,
> >
> > T G-R
bump
next prev parent reply other threads:[~2019-10-21 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 2:00 [bug#37642] [PATCH] gnu: Add filters Jesse Gibbons
2019-10-08 14:59 ` Tobias Geerinckx-Rice via Guix-patches via
2019-10-08 15:21 ` Tobias Geerinckx-Rice via Guix-patches via
2019-10-08 19:46 ` Jesse Gibbons
2019-10-09 13:14 ` Tobias Geerinckx-Rice via Guix-patches via
2019-10-10 4:40 ` Jesse Gibbons
2019-10-21 18:43 ` Jesse Gibbons [this message]
2019-10-27 1:45 ` Jesse Gibbons
2019-10-28 19:41 ` bug#37642: " Tobias Geerinckx-Rice via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2128be8b1e1810a47cf64a5a98288441709ae1a5.camel@gmail.com \
--to=jgibbons2357@gmail.com \
--cc=37642@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).