* [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
@ 2019-02-08 23:12 Amirouche Boubekki
2019-02-09 4:38 ` Eric Bavier
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Amirouche Boubekki @ 2019-02-08 23:12 UTC (permalink / raw)
To: 34393
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-termbox-truecolor.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-termbox-truecolor.patch, Size: 2549 bytes --]
From c97de00efc8dfe17a2cedda69033eaa710c42a6e Mon Sep 17 00:00:00 2001
From: Amirouche <amirouche.boubekki@gmail.com>
Date: Sat, 9 Feb 2019 00:07:48 +0100
Subject: [PATCH] gnu: Add termbox-truecolor.
* gnu/packages/terminals.scm (termbox-truecolor): New variable.
---
gnu/packages/terminals.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index 7f52c6efd..0ff0eda35 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -13,6 +13,7 @@
;;; Copyright © 2018 Arun Isaac <arunisaac@systemreboot.net>
;;; Copyright © 2018 Gabriel Hondet <gabrielhondet@gmail.com>
;;; Copyright © 2019 Rutger Helling <rhelling@mykolab.com>
+;;; Copyright © 2019 Amirouche Boubekki <amirouche@hypermove.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -36,6 +37,7 @@
#:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system go)
#:use-module (guix build-system python)
+ #:use-module (guix build-system waf)
#:use-module (guix download)
#:use-module (guix git-download)
#:use-module (guix packages)
@@ -1015,3 +1017,30 @@ arbitrary programs of your choice. This is useful for browsing the history
comfortably in a pager or editor.
@end itemize")
(license license:gpl3+)))
+
+(define-public termbox-truecolor
+ (package
+ (name "termbox-truecolor")
+ (version "2019.01.06-c3afbfd")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/amirouche/termbox-truecolor.git")
+ (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "179py858dhhxkj6la84b224r2fjwavygf4daw4dgl3gvv8i07ryj"))))
+ (build-system waf-build-system)
+ (arguments
+ `(#:tests? #f))
+ (synopsis "Library for writing text-based user interfaces (with true-color support)")
+ (description "Termbox is a library that provides minimalistic API which
+allows the programmer to write text-based user interfaces.
+
+It is based on a simple abstraction: viewing terminals as a table of
+fixed-size cells and input being a stream of structured messages. Copy &
+pasting and wide characters (mostly Chinese, Japanese, Korean (CJK)
+characters) are not really supported.")
+ (home-page "https://github.com/amirouche/termbox-truecolor/tree/truecolor")
+ (license license:expat)))
--
2.19.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
2019-02-08 23:12 [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor Amirouche Boubekki
@ 2019-02-09 4:38 ` Eric Bavier
2019-02-09 8:58 ` Ricardo Wurmus
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Eric Bavier @ 2019-02-09 4:38 UTC (permalink / raw)
To: Amirouche Boubekki; +Cc: 34393
[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]
> +(define-public termbox-truecolor
> + (package
> + (name "termbox-truecolor")
> + (version "2019.01.06-c3afbfd")
Could you include a revision number here too? (See "Version Numbers"
in the manual)
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/amirouche/termbox-truecolor.git")
> + (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "179py858dhhxkj6la84b224r2fjwavygf4daw4dgl3gvv8i07ryj"))))
> + (build-system waf-build-system)
> + (arguments
> + `(#:tests? #f))
> + (synopsis "Library for writing text-based user interfaces (with true-color support)")
Maybe: "Text-based user interface library"
The true-color support can be mentioned in the description.
> + (description "Termbox is a library that provides minimalistic API which
"...provides a minimalistic ..."
^
> +allows the programmer to write text-based user interfaces.
> +
> +It is based on a simple abstraction: viewing terminals as a table of
I think the paragraph break isn't necessary here.
> +fixed-size cells and input being a stream of structured messages. Copy &
> +pasting and wide characters (mostly Chinese, Japanese, Korean (CJK)
> +characters) are not really supported.")
> + (home-page "https://github.com/amirouche/termbox-truecolor/tree/truecolor")
> + (license license:expat)))
Otherwise looks good to me,
`~Eric
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
2019-02-08 23:12 [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor Amirouche Boubekki
2019-02-09 4:38 ` Eric Bavier
@ 2019-02-09 8:58 ` Ricardo Wurmus
2019-05-01 1:14 ` [bug#34393] Notice amirouche
2022-04-12 10:08 ` [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor zimoun
3 siblings, 0 replies; 7+ messages in thread
From: Ricardo Wurmus @ 2019-02-09 8:58 UTC (permalink / raw)
To: Amirouche Boubekki; +Cc: 34393
Hi Amirouche,
> From c97de00efc8dfe17a2cedda69033eaa710c42a6e Mon Sep 17 00:00:00 2001
> From: Amirouche <amirouche.boubekki@gmail.com>
> Date: Sat, 9 Feb 2019 00:07:48 +0100
> Subject: [PATCH] gnu: Add termbox-truecolor.
>
> * gnu/packages/terminals.scm (termbox-truecolor): New variable.
Thanks for the patch!
[…]
> +(define-public termbox-truecolor
> + (package
> + (name "termbox-truecolor")
> + (version "2019.01.06-c3afbfd")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/amirouche/termbox-truecolor.git")
> + (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))
It’s better to let-bind the commit and then use (git-version "1.1.0"
commit), because the last release was 1.1.0.
“2019.01.06” is not a version string and it would always be considered a
more recent version than other releases because 2019 is larger than most
major release numbers.
> + (arguments
> + `(#:tests? #f))
Could you tell us why the tests are disabled? If there are no tests
please add a comment “; there are no tests”.
> + (synopsis "Library for writing text-based user interfaces (with true-color support)")
I think “guix lint” said something about this synopsis being too long.
Could you shorten it a bit?
> + (home-page
> "https://github.com/amirouche/termbox-truecolor/tree/truecolor")
I think the “tree/truecolor” bit can be removed.
--
Ricardo
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#34393] Notice
2019-02-08 23:12 [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor Amirouche Boubekki
2019-02-09 4:38 ` Eric Bavier
2019-02-09 8:58 ` Ricardo Wurmus
@ 2019-05-01 1:14 ` amirouche
2019-05-01 11:04 ` amirouche
2022-04-12 10:08 ` [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor zimoun
3 siblings, 1 reply; 7+ messages in thread
From: amirouche @ 2019-05-01 1:14 UTC (permalink / raw)
To: 34393
I just noticed your comments. I will work on them tomorrow.
There is also the problem that upstream doesn't provide pkg-config file
: /
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#34393] Notice
2019-05-01 1:14 ` [bug#34393] Notice amirouche
@ 2019-05-01 11:04 ` amirouche
0 siblings, 0 replies; 7+ messages in thread
From: amirouche @ 2019-05-01 11:04 UTC (permalink / raw)
To: 34393
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
On 2019-05-01 03:14, amirouche@hyper.dev wrote:
> I just noticed your comments. I will work on them tomorrow.
Here is a new patch.
This is a fork of the upstream package which add truecolor support.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-add-termbox-truecolor.patch --]
[-- Type: text/x-diff; name=0001-gnu-add-termbox-truecolor.patch, Size: 2573 bytes --]
From 64fb39c1d1d436eb6b044238ce3177844bdb39bc Mon Sep 17 00:00:00 2001
From: Amirouche <amirouche+dev@hyper.dev>
Date: Wed, 1 May 2019 12:59:53 +0200
Subject: [PATCH] gnu: add termbox-truecolor
* gnu/packages/terminals.scm (termbox-truecolor): New variable.
---
gnu/packages/terminals.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index d0531b0c14..79759126ad 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -14,6 +14,7 @@
;;; Copyright © 2018 Gabriel Hondet <gabrielhondet@gmail.com>
;;; Copyright © 2019 Rutger Helling <rhelling@mykolab.com>
;;; Copyright © 2018, 2019 Eric Bavier <bavier@member.fsf.org>
+;;; Copyright © 2018, 2019 Amirouche Boubekki <amirouche@hyper.dev>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -37,6 +38,7 @@
#:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system go)
#:use-module (guix build-system python)
+ #:use-module (guix build-system waf)
#:use-module (guix download)
#:use-module (guix git-download)
#:use-module (guix packages)
@@ -888,6 +890,32 @@ per-line fullscreen terminal rendering, and keyboard input event reporting.")
(define-public python2-curtsies
(package-with-python2 python-curtsies))
+(define-public termbox-truecolor
+ (let ((commit "962a3d8bee04df75c47187a9910464718ea840aa")
+ (revision "0"))
+ (package
+ (name "termbox-truecolor")
+ (version (git-version "1.1.2" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/amirouche/termbox-truecolor.git")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0jkwczx7l36jrp11sp9yrhvgafg811ksxs7vl4ln7k6bw85qmm81"))))
+ (build-system waf-build-system)
+ (arguments
+ `(#:tests? #f)) ;; no tests
+ (synopsis "Text-based user interfaces library")
+ (description "Termbox is a library that provides a minimalistic
+API which allows the programmer to write text-based user interfaces with
+true-color support. It is based on a simple abstraction: viewing terminals as
+a table of fixed-size cells and input being a stream of structured messages.")
+ (home-page "https://github.com/amirouche/termbox-truecolor/")
+ (license license:expat))))
+
(define-public tmate
(package
(name "tmate")
--
2.19.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
2019-02-08 23:12 [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor Amirouche Boubekki
` (2 preceding siblings ...)
2019-05-01 1:14 ` [bug#34393] Notice amirouche
@ 2022-04-12 10:08 ` zimoun
2022-05-19 21:18 ` bug#34393: " zimoun
3 siblings, 1 reply; 7+ messages in thread
From: zimoun @ 2022-04-12 10:08 UTC (permalink / raw)
To: Amirouche Boubekki; +Cc: Ricardo Wurmus, 34393, Eric Bavier
Hi,
Thanks for the submission.
What is the status of this old patch submission [1]?
1: <http://issues.guix.gnu.org/issue/34393>
Since the last interaction is from 2 years, 49 weeks, 3 days ago, I
propose to rebase or close.
Cheers,
simon
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#34393: [PATCH] gnu: terminals: Add termbox-truecolor
2022-04-12 10:08 ` [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor zimoun
@ 2022-05-19 21:18 ` zimoun
0 siblings, 0 replies; 7+ messages in thread
From: zimoun @ 2022-05-19 21:18 UTC (permalink / raw)
To: Amirouche Boubekki; +Cc: Ricardo Wurmus, 34393-done, Eric Bavier
Hi,
On Tue, 12 Apr 2022 at 12:08, zimoun <zimon.toutoune@gmail.com> wrote:
> What is the status of this old patch submission [1]?
>
> 1: <http://issues.guix.gnu.org/issue/34393>
>
>
> Since the last interaction is from 2 years, 49 weeks, 3 days ago, I
> propose to rebase or close.
Since no one is willing to rebase, I am closing. Feel free to reopen.
Cheers,
simon
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-05-19 21:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-08 23:12 [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor Amirouche Boubekki
2019-02-09 4:38 ` Eric Bavier
2019-02-09 8:58 ` Ricardo Wurmus
2019-05-01 1:14 ` [bug#34393] Notice amirouche
2019-05-01 11:04 ` amirouche
2022-04-12 10:08 ` [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor zimoun
2022-05-19 21:18 ` bug#34393: " zimoun
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).