From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:47039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gsw1H-0004sk-EJ
	for guix-patches@gnu.org; Sun, 10 Feb 2019 15:48:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gsw0G-0002bY-Qq
	for guix-patches@gnu.org; Sun, 10 Feb 2019 15:47:06 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:43544)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gsw0E-0002Yx-FK
	for guix-patches@gnu.org; Sun, 10 Feb 2019 15:47:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gsw0E-000347-8b
	for guix-patches@gnu.org; Sun, 10 Feb 2019 15:47:02 -0500
Subject: [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
Resent-Message-ID: <handler.34393.B34393.154983158711733@debbugs.gnu.org>
References: <21686c5a9ff5047728ed5277a6bdd5a0@hypermove.net>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <21686c5a9ff5047728ed5277a6bdd5a0@hypermove.net>
Date: Sat, 09 Feb 2019 09:58:00 +0100
Message-ID: <878sypmj8n.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Amirouche Boubekki <amirouche@hypermove.net>
Cc: 34393@debbugs.gnu.org


Hi Amirouche,

> From c97de00efc8dfe17a2cedda69033eaa710c42a6e Mon Sep 17 00:00:00 2001
> From: Amirouche <amirouche.boubekki@gmail.com>
> Date: Sat, 9 Feb 2019 00:07:48 +0100
> Subject: [PATCH] gnu: Add termbox-truecolor.
>
> * gnu/packages/terminals.scm (termbox-truecolor): New variable.

Thanks for the patch!

[=E2=80=A6]
> +(define-public termbox-truecolor
> +  (package
> +    (name "termbox-truecolor")
> +    (version "2019.01.06-c3afbfd")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/amirouche/termbox-truecolor=
.git")
> +                    (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))

It=E2=80=99s better to let-bind the commit and then use (git-version "1.1.0"
commit), because the last release was 1.1.0.

=E2=80=9C2019.01.06=E2=80=9D is not a version string and it would always be=
 considered a
more recent version than other releases because 2019 is larger than most
major release numbers.
> +    (arguments
> +     `(#:tests? #f))

Could you tell us why the tests are disabled?  If there are no tests
please add a comment =E2=80=9C; there are no tests=E2=80=9D.

> +    (synopsis "Library for writing text-based user interfaces (with true=
-color support)")

I think =E2=80=9Cguix lint=E2=80=9D said something about this synopsis bein=
g too long.
Could you shorten it a bit?

> +    (home-page
> "https://github.com/amirouche/termbox-truecolor/tree/truecolor")

I think the =E2=80=9Ctree/truecolor=E2=80=9D bit can be removed.

--=20
Ricardo