From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55576) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMcex-00060J-2B for guix-patches@gnu.org; Mon, 21 Oct 2019 14:44:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMcev-0008P5-Sy for guix-patches@gnu.org; Mon, 21 Oct 2019 14:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49019) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMcev-0008P1-Pb for guix-patches@gnu.org; Mon, 21 Oct 2019 14:44:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMcev-0001ve-Mx for guix-patches@gnu.org; Mon, 21 Oct 2019 14:44:01 -0400 Subject: [bug#37642] [PATCH] gnu: Add filters Resent-Message-ID: Message-ID: <2128be8b1e1810a47cf64a5a98288441709ae1a5.camel@gmail.com> From: Jesse Gibbons In-Reply-To: <48d0e5df510f6551be63c9ec4545f06bdf7ffc5d.camel@gmail.com> References: <6f4a21523a30dcf3e3045aad994d8958c78a7b72.camel@gmail.com> <87lftv1dwb.fsf@nckx> <14cbe887a25f732826a1e920e2d0140dbce51893.camel@gmail.com> <87lftu9i2b.fsf@nckx> <48d0e5df510f6551be63c9ec4545f06bdf7ffc5d.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 21 Oct 2019 12:43:10 -0600 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 37642@debbugs.gnu.org On Wed, 2019-10-09 at 22:40 -0600, Jesse Gibbons wrote: > On Wed, 2019-10-09 at 15:14 +0200, Tobias Geerinckx-Rice wrote: > > Jesse, > > > > Jesse Gibbons 写道： > > > That review was a bit of a mess. Let's see if I can rephrase > > > what you want, > > > in a human-friendly format (no emacs involved): > > > > Yes, I'm so sorry. It looked fine while writing; I'm not actually > > on crack. > emacs might have been. > > > > Use a patch instead or move this to the source's snippet so > > > kenny is removed > > > from the raw source. > > > > A patch would contain a ‘negative’ verbatim copy of the non-free > > code so isn't an option here. > > > Moved it to source's snippet. > > > > + #:tests? #f)) > > > clarify we have no tests suite > > > > Yep. Ideally that comment would be redundant because we'd never > > flat-out disable tests in packages that have them, but we do. > > > rednotebook's test suite is disabled because it fails, but the program > itself works fine. There's a TODO note there to fix the tests. > > Added comment. > > > > > +The GNU project hosts a similar collection of filters, the GNU > > > > talkfilters. Due > > > > +to copyright concerns and difficulty in communication between > > > > maintainers, these > > > > +collections have not been merged.") > > > You want me to remove this. > > > I think it's appropriate to say something about gnu talkfilters > > > and note > > > that this is not the same package, given that filters and > > > talkfilters > > > packages are often confused with each other on the internet, > > > > OK. I didn't know they were often confused. Would it make sense > > to add it to GNU's, too? > > > > > but I will remove the last sentence. > > > > Great. It's the one that bothered me. > > > Sentence removed > > > If the comments go beyond 80 characters I will move the > > > comments above the license. > > > > For such whole-line comments you *would* use ‘;;’, start with a > > capital letter, and end with a full stop… > > > I was able to fit the comments after a line. > > > Am I missing anything? > - Cleaned up package descriptions. Only one takes up more than a line now, > and they focus more on behavior. > - Changed "80's" to "1980's" > - Fixed various typos > > New patch is attached. > > Kind regards, > > > > T G-R bump