unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#59560] [PATCH 1/2] gnu: Add emacs-function-args.
@ 2022-11-25  3:04 jgart via Guix-patches via
  2022-11-25  3:06 ` jgart via Guix-patches via
  2022-11-25  6:14 ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
  0 siblings, 2 replies; 7+ messages in thread
From: jgart via Guix-patches via @ 2022-11-25  3:04 UTC (permalink / raw)
  To: 59560

hiya,

this updates emacs-lpy and adds a missing input of emacs-function-args




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#59560] [PATCH 1/2] gnu: Add emacs-function-args.
  2022-11-25  3:04 [bug#59560] [PATCH 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
@ 2022-11-25  3:06 ` jgart via Guix-patches via
  2022-11-25  3:06   ` [bug#59560] [PATCH 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
  2022-11-25  6:14 ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
  1 sibling, 1 reply; 7+ messages in thread
From: jgart via Guix-patches via @ 2022-11-25  3:06 UTC (permalink / raw)
  To: 59560; +Cc: jgart

* gnu/packages/emacs-xyz.scm (emacs-function-args): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5d6f4d040f..ec1d59931d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11083,6 +11083,32 @@ (define-public emacs-lispyville
 state and will work even without lispy being enabled.")
       (license license:gpl3+))))
 
+(define-public emacs-function-args
+  ;; The latest release is from August 21, 2017.
+  (let ((commit "beba049751fed78666c87bd146a6f1cf149bb819")
+        (revision "0"))
+    (package
+      (name "emacs-function-args")
+      (version (git-version "0.6.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/abo-abo/function-args")
+               (commit commit)))
+         (sha256
+          (base32
+           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
+         (file-name (git-file-name name version))))
+      (propagated-inputs (list emacs-ivy))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/abo-abo/function-args")
+      (synopsis "C/C++ completion for GNU Emacs")
+      (description
+"GNU Emacs package for showing an inline arguments hint for the C/C++
+function at point.")
+      (license license:gpl3+))))
+
 (define-public emacs-lpy
   ;; There is no proper release/tag.
   (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#59560] [PATCH 2/2] gnu: emacs-lpy: Update to fa95b11.
  2022-11-25  3:06 ` jgart via Guix-patches via
@ 2022-11-25  3:06   ` jgart via Guix-patches via
  0 siblings, 0 replies; 7+ messages in thread
From: jgart via Guix-patches via @ 2022-11-25  3:06 UTC (permalink / raw)
  To: 59560; +Cc: jgart

* gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
[propagated-inputs]: Add missing emacs-function-args.
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ec1d59931d..fdb5b19477 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11111,7 +11111,7 @@ (define-public emacs-function-args
 
 (define-public emacs-lpy
   ;; There is no proper release/tag.
-  (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
+  (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
         (revision "5"))
     (package
       (name "emacs-lpy")
@@ -11127,7 +11127,7 @@ (define-public emacs-lpy
            "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
          (file-name (git-file-name name version))))
       (propagated-inputs
-       (list emacs-zoutline emacs-lispy))
+       (list emacs-zoutline emacs-lispy emacs-function-args))
       (build-system emacs-build-system)
       (home-page "https://github.com/abo-abo/lpy")
       (synopsis "Modal editing for Python")
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args.
  2022-11-25  3:04 [bug#59560] [PATCH 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
  2022-11-25  3:06 ` jgart via Guix-patches via
@ 2022-11-25  6:14 ` jgart via Guix-patches via
  2022-11-25  6:14   ` [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
  2022-11-26 10:33   ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args Nicolas Goaziou
  1 sibling, 2 replies; 7+ messages in thread
From: jgart via Guix-patches via @ 2022-11-25  6:14 UTC (permalink / raw)
  To: 59560; +Cc: jgart

* gnu/packages/emacs-xyz.scm (emacs-function-args): New variable.

Hi,

I forgut to include the hash update. Ignore v1 and use this v2 instead.

all best,

jgart
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5d6f4d040f..ec1d59931d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11083,6 +11083,32 @@ (define-public emacs-lispyville
 state and will work even without lispy being enabled.")
       (license license:gpl3+))))
 
+(define-public emacs-function-args
+  ;; The latest release is from August 21, 2017.
+  (let ((commit "beba049751fed78666c87bd146a6f1cf149bb819")
+        (revision "0"))
+    (package
+      (name "emacs-function-args")
+      (version (git-version "0.6.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/abo-abo/function-args")
+               (commit commit)))
+         (sha256
+          (base32
+           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
+         (file-name (git-file-name name version))))
+      (propagated-inputs (list emacs-ivy))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/abo-abo/function-args")
+      (synopsis "C/C++ completion for GNU Emacs")
+      (description
+"GNU Emacs package for showing an inline arguments hint for the C/C++
+function at point.")
+      (license license:gpl3+))))
+
 (define-public emacs-lpy
   ;; There is no proper release/tag.
   (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11.
  2022-11-25  6:14 ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
@ 2022-11-25  6:14   ` jgart via Guix-patches via
  2022-11-26 10:35     ` Nicolas Goaziou
  2022-11-26 10:33   ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args Nicolas Goaziou
  1 sibling, 1 reply; 7+ messages in thread
From: jgart via Guix-patches via @ 2022-11-25  6:14 UTC (permalink / raw)
  To: 59560; +Cc: jgart

* gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
[propagated-inputs]: Add missing emacs-function-args.
---
 gnu/packages/emacs-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ec1d59931d..b4ab6ec5c3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11111,8 +11111,8 @@ (define-public emacs-function-args
 
 (define-public emacs-lpy
   ;; There is no proper release/tag.
-  (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
-        (revision "5"))
+  (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
+        (revision "0"))
     (package
       (name "emacs-lpy")
       (version (git-version "0.1.0" revision commit))
@@ -11124,10 +11124,10 @@ (define-public emacs-lpy
                (commit commit)))
          (sha256
           (base32
-           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
+           "1j92ll2afvcp891fxra3sawxg000cs3ra01wxksiil2dg5zpzzkn"))
          (file-name (git-file-name name version))))
       (propagated-inputs
-       (list emacs-zoutline emacs-lispy))
+       (list emacs-zoutline emacs-lispy emacs-function-args))
       (build-system emacs-build-system)
       (home-page "https://github.com/abo-abo/lpy")
       (synopsis "Modal editing for Python")
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args.
  2022-11-25  6:14 ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
  2022-11-25  6:14   ` [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
@ 2022-11-26 10:33   ` Nicolas Goaziou
  1 sibling, 0 replies; 7+ messages in thread
From: Nicolas Goaziou @ 2022-11-26 10:33 UTC (permalink / raw)
  To: 59560; +Cc: jgart

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-function-args): New variable.

Thank you.

> +         (sha256
> +          (base32
> +           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
> +         (file-name (git-file-name name version))))

Nitpick: Usuallly the file-name field resides before sha256.

> +      (propagated-inputs (list emacs-ivy))
> +      (build-system emacs-build-system)

Other nitpick in the same vein: propagated-inputs usually come after
build-system field.

> +      (description
> +"GNU Emacs package for showing an inline arguments hint for the C/C++
> +function at point.")

This is not a complete sentence. I would also add that the package
extends C++ mode completion provided by CEDET. What about something
like:

  Function-args shows inline arguments hints exactly where the C/C++
  function call is, rather than in the minibuffer. It also extends C++
  mode completion provided by CEDET.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11.
  2022-11-25  6:14   ` [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
@ 2022-11-26 10:35     ` Nicolas Goaziou
  0 siblings, 0 replies; 7+ messages in thread
From: Nicolas Goaziou @ 2022-11-26 10:35 UTC (permalink / raw)
  To: 59560; +Cc: jgart

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
> [propagated-inputs]: Add missing emacs-function-args.

Thanks.

> -  (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
> -        (revision "5"))
> +  (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
> +        (revision "0"))

You should reset revision only when bumping base version. The fact that
commit happen to be sorted in the right order is too subtle. I vote for
(revision "6").

>      (package
>        (name "emacs-lpy")
>        (version (git-version "0.1.0" revision commit))
> @@ -11124,10 +11124,10 @@ (define-public emacs-lpy
>                 (commit commit)))
>           (sha256
>            (base32
> -           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
> +           "1j92ll2afvcp891fxra3sawxg000cs3ra01wxksiil2dg5zpzzkn"))
>           (file-name (git-file-name name version))))
>        (propagated-inputs
> -       (list emacs-zoutline emacs-lispy))
> +       (list emacs-zoutline emacs-lispy emacs-function-args))

While you're at it, could you sort inputs alphabetically, too?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-11-26 10:36 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25  3:04 [bug#59560] [PATCH 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
2022-11-25  3:06 ` jgart via Guix-patches via
2022-11-25  3:06   ` [bug#59560] [PATCH 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
2022-11-25  6:14 ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
2022-11-25  6:14   ` [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
2022-11-26 10:35     ` Nicolas Goaziou
2022-11-26 10:33   ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).