unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 59560@debbugs.gnu.org
Cc: jgart@dismail.de
Subject: [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11.
Date: Sat, 26 Nov 2022 11:35:47 +0100	[thread overview]
Message-ID: <875yf2c8ak.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20221125061426.23015-2-jgart@dismail.de> (jgart via Guix-patches via's message of "Fri, 25 Nov 2022 00:14:27 -0600")

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
> [propagated-inputs]: Add missing emacs-function-args.

Thanks.

> -  (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
> -        (revision "5"))
> +  (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
> +        (revision "0"))

You should reset revision only when bumping base version. The fact that
commit happen to be sorted in the right order is too subtle. I vote for
(revision "6").

>      (package
>        (name "emacs-lpy")
>        (version (git-version "0.1.0" revision commit))
> @@ -11124,10 +11124,10 @@ (define-public emacs-lpy
>                 (commit commit)))
>           (sha256
>            (base32
> -           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
> +           "1j92ll2afvcp891fxra3sawxg000cs3ra01wxksiil2dg5zpzzkn"))
>           (file-name (git-file-name name version))))
>        (propagated-inputs
> -       (list emacs-zoutline emacs-lispy))
> +       (list emacs-zoutline emacs-lispy emacs-function-args))

While you're at it, could you sort inputs alphabetically, too?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2022-11-26 10:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25  3:04 [bug#59560] [PATCH 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
2022-11-25  3:06 ` jgart via Guix-patches via
2022-11-25  3:06   ` [bug#59560] [PATCH 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
2022-11-25  6:14 ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args jgart via Guix-patches via
2022-11-25  6:14   ` [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11 jgart via Guix-patches via
2022-11-26 10:35     ` Nicolas Goaziou [this message]
2022-11-26 10:33   ` [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args Nicolas Goaziou
2023-04-04 18:59     ` bug#59560: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yf2c8ak.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=59560@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).