unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#58675] [PATCH] gnu: Add emacs-purs-mode.
@ 2022-10-21  5:33 jgart via Guix-patches via
  2022-10-21  8:06 ` bug#58675: " Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: jgart via Guix-patches via @ 2022-10-21  5:33 UTC (permalink / raw)
  To: 58675; +Cc: jgart

* gnu/packages/emacs-xyz.scm (emacs-purs-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c41e7ce127..4cba5eea0d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -33410,6 +33410,29 @@ (define-public emacs-consult-lsp
 by leveraging @code{emacs-consult} APIs.")
     (license license:expat)))
 
+(define-public emacs-purs-mode
+  (let ((commit "d29f1021787a90d0fd3eb0af625958abb7f7506b")
+        (revision "0"))
+    (package
+      (name "emacs-purs-mode")
+      (version (git-version "20220827" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/PureFunctor/purs-mode")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1ir0fli8ic3fhp0z2z3kkiirhkwjsdg567kxfvd2awzv27d32c3n"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/PureFunctor/purs-mode/")
+      (synopsis "Yet another PureScript mode for Emacs")
+      (description
+"@code{emacs-purs-mode} provides yet another PureScript mode for Emacs.")
+      (license license:gpl3+))))
+
 (define-public emacs-pdb-capf
   (let ((commit "31602ccab53aa7dcf26a1af222c7da2bcc1390ed")
         (revision "0"))
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#58675: [PATCH] gnu: Add emacs-purs-mode.
  2022-10-21  5:33 [bug#58675] [PATCH] gnu: Add emacs-purs-mode jgart via Guix-patches via
@ 2022-10-21  8:06 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2022-10-21  8:06 UTC (permalink / raw)
  To: jgart via Guix-patches via; +Cc: 58675-done, jgart

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-purs-mode): New variable.

Thanks. Applied with the following changes.

> +    (package
> +      (name "emacs-purs-mode")
> +      (version (git-version "20220827" revision commit))

There is no tag, and no Version keyword. Therefore, the base version
should be "0", not the date of the last commit.

> +         (sha256
> +          (base32 "1ir0fli8ic3fhp0z2z3kkiirhkwjsdg567kxfvd2awzv27d32c3n"))))

The hash above was wrong, so I updated it.

> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/PureFunctor/purs-mode/")
> +      (synopsis "Yet another PureScript mode for Emacs")

I removed "Yet anoter" and added "major" in front of "mode".

> +      (description
> +"@code{emacs-purs-mode} provides yet another PureScript mode for
> Emacs.")

emacs-purs-mode is the name of the internal Guix variable bound to the
package definition. The project is purs-mode, or Purs mode (as is
preferred in, e.g., the Emacs manual).

The description is rather terse, but so it the upstream documentation…
In any case, I also removed "yet another" and added "major" in front of
"mode".

Regards,

-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-21  8:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-21  5:33 [bug#58675] [PATCH] gnu: Add emacs-purs-mode jgart via Guix-patches via
2022-10-21  8:06 ` bug#58675: " Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).