unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches@gnu.org>
Cc: 58675-done@debbugs.gnu.org, jgart <jgart@dismail.de>
Subject: bug#58675: [PATCH] gnu: Add emacs-purs-mode.
Date: Fri, 21 Oct 2022 10:06:13 +0200	[thread overview]
Message-ID: <87wn8tfvnu.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20221021053356.26608-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Fri, 21 Oct 2022 00:33:56 -0500")

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-purs-mode): New variable.

Thanks. Applied with the following changes.

> +    (package
> +      (name "emacs-purs-mode")
> +      (version (git-version "20220827" revision commit))

There is no tag, and no Version keyword. Therefore, the base version
should be "0", not the date of the last commit.

> +         (sha256
> +          (base32 "1ir0fli8ic3fhp0z2z3kkiirhkwjsdg567kxfvd2awzv27d32c3n"))))

The hash above was wrong, so I updated it.

> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/PureFunctor/purs-mode/")
> +      (synopsis "Yet another PureScript mode for Emacs")

I removed "Yet anoter" and added "major" in front of "mode".

> +      (description
> +"@code{emacs-purs-mode} provides yet another PureScript mode for
> Emacs.")

emacs-purs-mode is the name of the internal Guix variable bound to the
package definition. The project is purs-mode, or Purs mode (as is
preferred in, e.g., the Emacs manual).

The description is rather terse, but so it the upstream documentation…
In any case, I also removed "yet another" and added "major" in front of
"mode".

Regards,

-- 
Nicolas Goaziou




      reply	other threads:[~2022-10-21  8:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21  5:33 [bug#58675] [PATCH] gnu: Add emacs-purs-mode jgart via Guix-patches via
2022-10-21  8:06 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn8tfvnu.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=58675-done@debbugs.gnu.org \
    --cc=guix-patches@gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).