From: Julien Lepiller <julien@lepiller.eu>
To: Jacob Hrbek <kreyren@rixotstudio.cz>
Cc: david larsson <david.larsson@selfhosted.xyz>, 51944-done@debbugs.gnu.org
Subject: bug#51944: [PATCH] Shell2Batch: New Package
Date: Thu, 18 Nov 2021 23:46:35 +0100 [thread overview]
Message-ID: <20211118234635.7842e026@tachikoma.lepiller.eu> (raw)
In-Reply-To: <G9TtnnyFxHpsqvTXbN1a7GABV3jBM4RCM4UysImjeyyyOzFLpLx03aLS4E7CnkJ6OO8WsTwVL3TmyLC2yedkJDdrOoJJcIzFtLqoHR3_TOY=@rixotstudio.cz>
Thanks for the patch! Pushed to master as
92d6f17dfd449208a657a1a54e3a287ae22d1da8.
I took the liberty to fix some parts of it that didn't correspond to
our standards. Have a look at the packaging guidelines in the manual to
better understand:
https://guix.gnu.org/manual/devel/en/html_node/Packaging-Guidelines.html
First, I renamed the patch file to rust-shell2batch-lint-fix.patch, so
it starts with the name of the package. I also modified a little bit
your message in the patch, to reference the issue there too, format at
80 lines and simplify the wording. I also added the patch file to
dist_patch_DATA, in gnu/local.mk. Whenever you add a patch file, please
make sure to add a reference in gnu/local.mk. This is necessary for
correctly generating the release tarballs.
Then, I fixed a few things in the package itself: I replaced tabs with
spaces and removed the empty line at the end of the file. I changed the
synopsis a bit so it better aligns with the rest of guix and removed
the period at the end. I also changed the description, mostly to wrap
it at 80 characters.
Finally, I fixed the commit message so it respects our conventions.
You'll find more info in the link above, and a lot of examples in the
git log history.
Some of these issues would have been caught by "guix lint
rust-shell2batch", I encourage you to run it on your next submissions :)
Have fun with guix :D
next prev parent reply other threads:[~2021-11-18 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 11:41 [bug#51944] [PATCH] Shell2Batch: New Package Jacob Hrbek
2021-11-18 11:48 ` [bug#51944] Build log Jacob Hrbek
2021-11-18 19:04 ` [bug#51944] New patch on roptat's request Jacob Hrbek
2021-11-18 19:32 ` [bug#51944] [PATCH] Shell2Batch: New Package david larsson
2021-11-18 19:39 ` Jacob Hrbek
2021-11-18 21:51 ` david larsson
2021-11-18 22:46 ` Julien Lepiller [this message]
2021-11-18 19:34 ` [bug#51944] Added skip-build as requested by rekado_ Jacob Hrbek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118234635.7842e026@tachikoma.lepiller.eu \
--to=julien@lepiller.eu \
--cc=51944-done@debbugs.gnu.org \
--cc=david.larsson@selfhosted.xyz \
--cc=kreyren@rixotstudio.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).