From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yC6tBivYlmFGhgEAgWs5BA (envelope-from ) for ; Thu, 18 Nov 2021 23:48:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CMl4ASvYlmGzIQAAbx9fmQ (envelope-from ) for ; Thu, 18 Nov 2021 22:48:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EC90F28FB0 for ; Thu, 18 Nov 2021 23:48:09 +0100 (CET) Received: from localhost ([::1]:43048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnqCO-0003nS-J2 for larch@yhetil.org; Thu, 18 Nov 2021 17:48:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnqCI-0003mv-SR for guix-patches@gnu.org; Thu, 18 Nov 2021 17:48:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnqCI-0007Ob-KC for guix-patches@gnu.org; Thu, 18 Nov 2021 17:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnqCI-0001A0-AZ for guix-patches@gnu.org; Thu, 18 Nov 2021 17:48:02 -0500 Subject: bug#51944: [PATCH] Shell2Batch: New Package Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 18 Nov 2021 22:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 51944 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jacob Hrbek Cc: david larsson , 51944-done@debbugs.gnu.org Mail-Followup-To: 51944@debbugs.gnu.org, julien@lepiller.eu, kreyren@rixotstudio.cz Received: via spool by 51944-done@debbugs.gnu.org id=D51944.16372756294374 (code D ref 51944); Thu, 18 Nov 2021 22:48:02 +0000 Received: (at 51944-done) by debbugs.gnu.org; 18 Nov 2021 22:47:09 +0000 Received: from localhost ([127.0.0.1]:37375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnqBR-00018U-7S for submit@debbugs.gnu.org; Thu, 18 Nov 2021 17:47:09 -0500 Received: from lepiller.eu ([89.234.186.109]:39196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnqBO-00018I-OU for 51944-done@debbugs.gnu.org; Thu, 18 Nov 2021 17:47:07 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id cea3a8de; Thu, 18 Nov 2021 22:47:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=9i8mt1dxkF2L BFsCwfonF+moE1AhmMr9rlu33mmWmtI=; b=M8HTwglstATG/B/+LLHnvPmgyXzs PBwXtb3ZO4ne1d+gzCbsx7wyWAGcZ0H2uXAXWEeWDa4KqWit8+b4byX/N6vgjNjT ymd2i6u+2/kxS8RuDgAlaY+m0BW4PrY7ihi3EUiHVU6dqZkhEcCjV63uxyVetR+f PgNoy1Q0q2Q1bXUxeb5xlRfywaSKZXodj6kh6ZPEUUqvZSLk4DFrNdVXfBAEgVK5 EuGXemX8DYL/FeKvhmcVENUsF1vEl7Z1SYhAXEblwbclc4ojw1pzmzjsqa8jxhIc 27zhGXARpzNUVmJ92ubzDQ19zOxVwFjSctuVxouxwmH5nd1rBUBzHTZaVw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id e3195dcb (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 18 Nov 2021 22:47:04 +0000 (UTC) Date: Thu, 18 Nov 2021 23:46:35 +0100 From: Julien Lepiller Message-ID: <20211118234635.7842e026@tachikoma.lepiller.eu> In-Reply-To: References: <4123b093aa23d4d5e4724e61b902bb48@selfhosted.xyz> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637275690; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9i8mt1dxkF2LBFsCwfonF+moE1AhmMr9rlu33mmWmtI=; b=WCqc8Iz1VhJX0Ag5COO3Ifb00xieDaRMsVRTkh2c0CK4YaH8H9q7HDoy6Ivzz9cwqYU/j5 uwrtcUH7EUbrHpbX+vjjdSq2HJuCiPeSO3bb8t3bD/nHUGs9/rNYRLDtjvo4b2na2n6x6/ R2OUygOjsOwO3tPffba1nZThuJUcMiARK3MlYMGMpQo222D9/JjDnyh9RIeBFTKr5QjW40 2XcmpAPH5dV9G0rCVWcd/fgNUcWvI8JfaR06/RKJXTieE5ecq6rksNmT9V32KaAbA3KYMg 9oztp/1k0H4sETR9gBcTGDuqwoBSwxW++aUT04QtQCGsYN2h6l88KbPLBK3vIw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637275690; a=rsa-sha256; cv=none; b=h/iUdOkMq7gKCf8AuW2fRZuNEX9lEeQ06jS3kEt2PRzpmEEoxx5WG7Yy2Njy7UBO5EKYid HjsdZI6yfshRwI8vnOw6wTyhS2spv+WBTtAvI6D5jWASw5w0UPxJ2rgFSHKkx7S5gUOL7K Sd9J651RHEoYcnaOyTCR/Zm0GNoes0sIZj62jEi6atcDvd1xaLv1NOnmv2DpBpKM06nHCA ++E2bZKC93QF8rMpt+5pYULITDwd685WvxoCuu7z0vIRf4xuxUY9JkDvAPIMChk/9KoQqa 3y8tZjmuboPCh5rpW/noeFiw/MoEwywgSCHg5v+Xx0MsmfRM6Uk8E/AccivCUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=M8HTwgls; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=M8HTwgls; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EC90F28FB0 X-Spam-Score: -1.76 X-Migadu-Scanner: scn1.migadu.com X-TUID: zC8C8ds/c1QL Thanks for the patch! Pushed to master as 92d6f17dfd449208a657a1a54e3a287ae22d1da8. I took the liberty to fix some parts of it that didn't correspond to our standards. Have a look at the packaging guidelines in the manual to better understand: https://guix.gnu.org/manual/devel/en/html_node/Packaging-Guidelines.html First, I renamed the patch file to rust-shell2batch-lint-fix.patch, so it starts with the name of the package. I also modified a little bit your message in the patch, to reference the issue there too, format at 80 lines and simplify the wording. I also added the patch file to dist_patch_DATA, in gnu/local.mk. Whenever you add a patch file, please make sure to add a reference in gnu/local.mk. This is necessary for correctly generating the release tarballs. Then, I fixed a few things in the package itself: I replaced tabs with spaces and removed the empty line at the end of the file. I changed the synopsis a bit so it better aligns with the rest of guix and removed the period at the end. I also changed the description, mostly to wrap it at 80 characters. Finally, I fixed the commit message so it respects our conventions. You'll find more info in the link above, and a lot of examples in the git log history. Some of these issues would have been caught by "guix lint rust-shell2batch", I encourage you to run it on your next submissions :) Have fun with guix :D