unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: david larsson <david.larsson@selfhosted.xyz>
To: Jacob Hrbek <kreyren@rixotstudio.cz>
Cc: Guix-patches
	<guix-patches-bounces+david.larsson=selfhosted.xyz@gnu.org>,
	51944@debbugs.gnu.org
Subject: [bug#51944] [PATCH] Shell2Batch: New Package
Date: Thu, 18 Nov 2021 22:51:48 +0100	[thread overview]
Message-ID: <12e4fed645fb7a01775260ee657f89d8@selfhosted.xyz> (raw)
In-Reply-To: <G9TtnnyFxHpsqvTXbN1a7GABV3jBM4RCM4UysImjeyyyOzFLpLx03aLS4E7CnkJ6OO8WsTwVL3TmyLC2yedkJDdrOoJJcIzFtLqoHR3_TOY=@rixotstudio.cz>

I should have also mentioned this part (my apologies):

"Synopses must start with a capital letter and must not end with a 
period." - 
https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

your patch ends with a period in the synopsis. That needs fixed.

(I do not have commit access. Im just reviewing your patch to prepare it 
for being committed)

Best regards,
David




  reply	other threads:[~2021-11-18 21:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 11:41 [bug#51944] [PATCH] Shell2Batch: New Package Jacob Hrbek
2021-11-18 11:48 ` [bug#51944] Build log Jacob Hrbek
2021-11-18 19:04 ` [bug#51944] New patch on roptat's request Jacob Hrbek
2021-11-18 19:32 ` [bug#51944] [PATCH] Shell2Batch: New Package david larsson
2021-11-18 19:39   ` Jacob Hrbek
2021-11-18 21:51     ` david larsson [this message]
2021-11-18 22:46     ` bug#51944: " Julien Lepiller
2021-11-18 19:34 ` [bug#51944] Added skip-build as requested by rekado_ Jacob Hrbek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12e4fed645fb7a01775260ee657f89d8@selfhosted.xyz \
    --to=david.larsson@selfhosted.xyz \
    --cc=51944@debbugs.gnu.org \
    --cc=guix-patches-bounces+david.larsson=selfhosted.xyz@gnu.org \
    --cc=kreyren@rixotstudio.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).