* [bug#41027] [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8.
@ 2020-05-02 14:44 Christopher Baines
2020-05-13 18:10 ` bug#41027: " Christopher Baines
0 siblings, 1 reply; 2+ messages in thread
From: Christopher Baines @ 2020-05-02 14:44 UTC (permalink / raw)
To: 41027
* gnu/packages/python-web.scm (python-s3transfer)[arguments]: Add a 'patch
phase to fix a test to work under Python 3.8.
---
gnu/packages/python-web.scm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 27749246d8..56887ef9d4 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -2204,6 +2204,15 @@ Betamax.")
(arguments
`(#:phases
(modify-phases %standard-phases
+ (add-after 'unpack 'patch
+ (lambda _
+ ;; There's a small issue with one test with Python 3.8, this
+ ;; change has been suggested upstream:
+ ;; https://github.com/boto/s3transfer/pull/164
+ (substitute* "tests/unit/test_s3transfer.py"
+ (("super\\(FailedDownloadParts, self\\)\\.submit\\(function\\)")
+ "futures.Future()"))
+ #t))
(replace 'check
(lambda _
;; Some of the 'integration' tests require network access or
--
2.26.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#41027: [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8.
2020-05-02 14:44 [bug#41027] [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8 Christopher Baines
@ 2020-05-13 18:10 ` Christopher Baines
0 siblings, 0 replies; 2+ messages in thread
From: Christopher Baines @ 2020-05-13 18:10 UTC (permalink / raw)
To: 41027-done
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
Christopher Baines <mail@cbaines.net> writes:
> * gnu/packages/python-web.scm (python-s3transfer)[arguments]: Add a 'patch
> phase to fix a test to work under Python 3.8.
> ---
> gnu/packages/python-web.scm | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 27749246d8..56887ef9d4 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -2204,6 +2204,15 @@ Betamax.")
> (arguments
> `(#:phases
> (modify-phases %standard-phases
> + (add-after 'unpack 'patch
> + (lambda _
> + ;; There's a small issue with one test with Python 3.8, this
> + ;; change has been suggested upstream:
> + ;; https://github.com/boto/s3transfer/pull/164
> + (substitute* "tests/unit/test_s3transfer.py"
> + (("super\\(FailedDownloadParts, self\\)\\.submit\\(function\\)")
> + "futures.Future()"))
> + #t))
> (replace 'check
> (lambda _
> ;; Some of the 'integration' tests require network access or
I pushed this as c63bd847816061e76389e93dc094df98800f081b back on the
4th of May, but forgot to close the bug.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-13 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-02 14:44 [bug#41027] [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8 Christopher Baines
2020-05-13 18:10 ` bug#41027: " Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).