unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: 41027-done@debbugs.gnu.org
Subject: bug#41027: [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8.
Date: Wed, 13 May 2020 19:10:21 +0100	[thread overview]
Message-ID: <87lflvogdu.fsf@cbaines.net> (raw)
In-Reply-To: <20200502144441.1489-1-mail@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]


Christopher Baines <mail@cbaines.net> writes:

> * gnu/packages/python-web.scm (python-s3transfer)[arguments]: Add a 'patch
> phase to fix a test to work under Python 3.8.
> ---
>  gnu/packages/python-web.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 27749246d8..56887ef9d4 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -2204,6 +2204,15 @@ Betamax.")
>      (arguments
>       `(#:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'patch
> +           (lambda _
> +             ;; There's a small issue with one test with Python 3.8, this
> +             ;; change has been suggested upstream:
> +             ;; https://github.com/boto/s3transfer/pull/164
> +             (substitute* "tests/unit/test_s3transfer.py"
> +               (("super\\(FailedDownloadParts, self\\)\\.submit\\(function\\)")
> +                "futures.Future()"))
> +             #t))
>           (replace 'check
>             (lambda _
>               ;; Some of the 'integration' tests require network access or

I pushed this as c63bd847816061e76389e93dc094df98800f081b back on the
4th of May, but forgot to close the bug.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

      reply	other threads:[~2020-05-13 18:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 14:44 [bug#41027] [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8 Christopher Baines
2020-05-13 18:10 ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lflvogdu.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=41027-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).