unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Michael Zucchi <notzed@gmail.com>
Cc: 40918@debbugs.gnu.org
Subject: [bug#40918] [PATCH] openjdk 14 package
Date: Wed, 29 Apr 2020 23:01:55 +0200	[thread overview]
Message-ID: <20200429230155.0e4f53d9@alma-ubu> (raw)
In-Reply-To: <db218c03-eed0-f10d-60a2-88af45e56165@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

Hi Michael,

On Wed, 29 Apr 2020 09:17:22 +0930
Michael Zucchi <notzed@gmail.com> wrote:

> > Please update your commit message according to the Changelog-style.
> > You will find examples in the old commit logs, for example for how
> > to add the patch-file.

> I'm sorry i don't understand your second point, i used emacs
> changelog mode to create the commit message.

Let me try to explain that in more details. Guix is the pickiest
project I came along when it comes to commit messages. It took me a
while to get used to it. So please this shouldn't be a show-stopper for
you :-) In the end, a commiter can/will correct it.

Your git log consists of only one line:

* gnu/packages/java.scm (openjdk13, opnejdk14) * gnu/packages/patches/openjdk-14-builtins.patch: Added openjdk 13 and 14.

I would have expected something like:

----BEGIN EXAMPLE---
gnu: Add openjdk14.

* gnu/packages/java.scm (openjdk14): New variable.
* gnu/packages/patches/openjdk...patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
----END EXAMPLE---

So you really document every file you add, every variable/location
where you change something.

It is somewhat explained here, but at best look through older commits:

https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html#Submitting-Patches
https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs

Hope this explains it better,

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2020-04-29 21:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  1:26 [bug#40918] [PATCH] openjdk 14 package Michael Zucchi
2020-04-28  1:34 ` [bug#40918] update Michael Zucchi
2020-04-28 22:38 ` [bug#40918] [PATCH] openjdk 14 package Björn Höfling
2020-04-28 23:47   ` Michael Zucchi
2020-04-29 21:01     ` Björn Höfling [this message]
2020-05-16  9:54       ` bug#40918: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429230155.0e4f53d9@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=40918@debbugs.gnu.org \
    --cc=notzed@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).