From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iKi4NIjrqV7yCAAA0tVLHw (envelope-from ) for ; Wed, 29 Apr 2020 21:03:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kGtGCZHrqV64ZgAAB5/wlQ (envelope-from ) for ; Wed, 29 Apr 2020 21:03:13 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C53B9408BA for ; Wed, 29 Apr 2020 21:03:12 +0000 (UTC) Received: from localhost ([::1]:38418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTtrL-0004Iu-Vs for larch@yhetil.org; Wed, 29 Apr 2020 17:03:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57324) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTtrG-0004GK-5R for guix-patches@gnu.org; Wed, 29 Apr 2020 17:03:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTtrD-0000k5-6y for guix-patches@gnu.org; Wed, 29 Apr 2020 17:03:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33254) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTtrC-0000jy-Qn for guix-patches@gnu.org; Wed, 29 Apr 2020 17:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTtrC-0007AZ-FC for guix-patches@gnu.org; Wed, 29 Apr 2020 17:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40918] [PATCH] openjdk 14 package Resent-From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Apr 2020 21:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40918 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Michael Zucchi Cc: 40918@debbugs.gnu.org Received: via spool by 40918-submit@debbugs.gnu.org id=B40918.158819413727505 (code B ref 40918); Wed, 29 Apr 2020 21:03:02 +0000 Received: (at 40918) by debbugs.gnu.org; 29 Apr 2020 21:02:17 +0000 Received: from localhost ([127.0.0.1]:44800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTtqF-00079M-NK for submit@debbugs.gnu.org; Wed, 29 Apr 2020 17:02:16 -0400 Received: from m4s11.vlinux.de ([83.151.27.109]:59064 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTtqA-00078t-Fh for 40918@debbugs.gnu.org; Wed, 29 Apr 2020 17:02:02 -0400 Received: from alma-ubu (p508ACF57.dip0.t-ipconnect.de [80.138.207.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 74C0D3F886; Wed, 29 Apr 2020 23:01:56 +0200 (CEST) Date: Wed, 29 Apr 2020 23:01:55 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20200429230155.0e4f53d9@alma-ubu> In-Reply-To: References: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> <20200429003859.3abd5a7a@alma-ubu> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/5/s_lp=5QHS/KFhQZzJMNMm"; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: 0.64 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [0.64 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49348679104521]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.17), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_MIXED_CHARSET(1.25)[subject]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; R_DKIM_NA(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[bjoern.hoefling@bjoernhoefling.de,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:url]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[bjoernhoefling.de]; HAS_LIST_UNSUB(-0.01)[]; RECEIVED_SPAMHAUS_PBL(0.00)[80.138.207.87:received]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: vdA3GyIpG4xf --Sig_/5/s_lp=5QHS/KFhQZzJMNMm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Michael, On Wed, 29 Apr 2020 09:17:22 +0930 Michael Zucchi wrote: > > Please update your commit message according to the Changelog-style. > > You will find examples in the old commit logs, for example for how > > to add the patch-file. > I'm sorry i don't understand your second point, i used emacs > changelog mode to create the commit message. Let me try to explain that in more details. Guix is the pickiest project I came along when it comes to commit messages. It took me a while to get used to it. So please this shouldn't be a show-stopper for you :-) In the end, a commiter can/will correct it. Your git log consists of only one line: * gnu/packages/java.scm (openjdk13, opnejdk14) * gnu/packages/patches/openj= dk-14-builtins.patch: Added openjdk 13 and 14. I would have expected something like: ----BEGIN EXAMPLE--- gnu: Add openjdk14. * gnu/packages/java.scm (openjdk14): New variable. * gnu/packages/patches/openjdk...patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. ----END EXAMPLE--- So you really document every file you add, every variable/location where you change something. It is somewhat explained here, but at best look through older commits: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html#Submitting= -Patches https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs Hope this explains it better, Bj=C3=B6rn --Sig_/5/s_lp=5QHS/KFhQZzJMNMm Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCXqnrQwAKCRC/KGy2WT5f /c/zAKC4cWym22SW9/KCknlAKmt0L1nNYgCbBi9nsLCHmR3ou+CDrxjrUYW7I3M= =ii1c -----END PGP SIGNATURE----- --Sig_/5/s_lp=5QHS/KFhQZzJMNMm--