unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Zucchi <notzed@gmail.com>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: 40918@debbugs.gnu.org
Subject: [bug#40918] [PATCH] openjdk 14 package
Date: Wed, 29 Apr 2020 09:17:22 +0930	[thread overview]
Message-ID: <db218c03-eed0-f10d-60a2-88af45e56165@gmail.com> (raw)
In-Reply-To: <20200429003859.3abd5a7a@alma-ubu>

On 29/4/20 8:08 am, Björn Höfling wrote:
> On Tue, 28 Apr 2020 10:56:55 +0930
> Michael Zucchi <notzed@gmail.com> wrote:
>
>> This mostly is just a simple copy of openjdk12 with changed links.
>> openjdk13 is also included as it must be used to bootstrap openjdk14.
>>
>> openjdk14 uses "help" as a rather poor choice of autoconf test for
>> the availability of a shell builtin and this isn't available in
>> bash-minimal, so a small patch is needed to make configure complete.
>> I've contacted the openjdk developers with a suggested change but so
>> far have had no response after a couple of business days.
>>
>>
> Hi Michael,
>
> thank you for your patch.
>
> When sending in the second version of your
> patch, could you please split up the commits, having one distinct
> commit per added/changed package.
>
> Please update your commit message according to the Changelog-style. You
> will find examples in the old commit logs, for example for how to add
> the patch-file.
>
> Excited to see your second version,
>
> Björn
>



I'm sorry i don't understand your second point, i used emacs changelog 
mode to create the commit message.

  reply	other threads:[~2020-04-28 23:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  1:26 [bug#40918] [PATCH] openjdk 14 package Michael Zucchi
2020-04-28  1:34 ` [bug#40918] update Michael Zucchi
2020-04-28 22:38 ` [bug#40918] [PATCH] openjdk 14 package Björn Höfling
2020-04-28 23:47   ` Michael Zucchi [this message]
2020-04-29 21:01     ` Björn Höfling
2020-05-16  9:54       ` bug#40918: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db218c03-eed0-f10d-60a2-88af45e56165@gmail.com \
    --to=notzed@gmail.com \
    --cc=40918@debbugs.gnu.org \
    --cc=bjoern.hoefling@bjoernhoefling.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).