unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 38538-done@debbugs.gnu.org
Subject: bug#38538: [PATCH] gnu: Add gnome-shell-extension-hide-app-icon
Date: Fri, 20 Dec 2019 09:02:42 +0200	[thread overview]
Message-ID: <20191220070242.GB16523@E5400> (raw)
In-Reply-To: <4f12bf6507870d42bd2b839e93cfc1db939d6ea8.camel@student.tugraz.at>

[-- Attachment #1: Type: text/plain, Size: 2401 bytes --]

On Thu, Dec 19, 2019 at 03:06:27PM +0100, Leo Prikler wrote:
> Am Donnerstag, den 19.12.2019, 15:38 +0200 schrieb Efraim Flashner:
> > On Thu, Dec 19, 2019 at 01:44:47PM +0100, Leo Prikler wrote:
> > > Am Donnerstag, den 19.12.2019, 12:00 +0100 schrieb Leo Prikler:
> > > > Am Donnerstag, den 19.12.2019, 11:20 +0200 schrieb Efraim
> > > > Flashner:
> > > > > What does this need glib and glib:bin for? Is it just for
> > > > > building
> > > > > the
> > > > > schemas or does it actually need it at runtime?
> > > > To be honest, I'm not quite sure.  I've copied this part from my
> > > > dash-
> > > > to-dock extension, wherein I copied it from the gnome-shell-
> > > > extensions
> > > > package.
> > > > 
> > > > As far as I'm aware both packages do build schemas, but I'm not
> > > > sure
> > > > how extensions handle them at runtime.  Perhaps this is already
> > > > wrong
> > > > in the package I originally copied the snippet from.  I'll try to
> > > > see
> > > > how far I can get with depropagation.
> > > > 
> > > > Regards,
> > > > Leo
> > > Upon closer inspection, it appears depropagation is indeed
> > > possible. 
> > > See the attached patch.
> > 
> > It makes sense to me that glib:bin should be a native-input but I
> > assume
> > glib, if it's needed at runtime, would probably need to be propagated
> > since the extension doesn't refer to it. Likely it's getting glib
> > from
> > another package in the environment.
> I'm not really sure, what the correct thing would be here.  I did have
> very weird behaviour with hide-app-icon, where having glib as input vs.
> not having it made the difference of having to reload the extension
> after changing settings vs. not having to.  However, I'm really not
> sure whether that was due to the extension or a weirdness in GNOME
> Shell.
> 

In any case, I've pushed the patch with glib:bin in native-inputs and
glib in propagated-inputs.

> > Also, the depropagation patch should really be a separate patch for
> > each
> > package if we go that route.
> Perhaps.  I just wanted to "prove" that you can at least depropagate
> glib:bin and probably glib as well.
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-12-20  7:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-08 20:12 [bug#38538] [PATCH] gnu: Add gnome-shell-extension-hide-app-icon Leo Prikler
2019-12-19  9:20 ` Efraim Flashner
2019-12-19  9:22   ` Efraim Flashner
2019-12-19 11:00   ` Leo Prikler
2019-12-19 12:44     ` Leo Prikler
2019-12-19 13:38       ` Efraim Flashner
2019-12-19 14:06         ` Leo Prikler
2019-12-20  7:02           ` Efraim Flashner [this message]
2019-12-22 15:33             ` Leo Prikler
2019-12-23  7:41               ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191220070242.GB16523@E5400 \
    --to=efraim@flashner.co.il \
    --cc=38538-done@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).