From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 38538@debbugs.gnu.org
Subject: [bug#38538] [PATCH] gnu: Add gnome-shell-extension-hide-app-icon
Date: Thu, 19 Dec 2019 13:44:47 +0100 [thread overview]
Message-ID: <15831159f236fe1a0e31d5882580c4d049a9522b.camel@student.tugraz.at> (raw)
In-Reply-To: <be32bfed7df3dc78380c27e703d6bbcd3b29d99d.camel@student.tugraz.at>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
Am Donnerstag, den 19.12.2019, 12:00 +0100 schrieb Leo Prikler:
> Am Donnerstag, den 19.12.2019, 11:20 +0200 schrieb Efraim Flashner:
> > What does this need glib and glib:bin for? Is it just for building
> > the
> > schemas or does it actually need it at runtime?
> To be honest, I'm not quite sure. I've copied this part from my
> dash-
> to-dock extension, wherein I copied it from the gnome-shell-
> extensions
> package.
>
> As far as I'm aware both packages do build schemas, but I'm not sure
> how extensions handle them at runtime. Perhaps this is already wrong
> in the package I originally copied the snippet from. I'll try to see
> how far I can get with depropagation.
>
> Regards,
> Leo
Upon closer inspection, it appears depropagation is indeed possible.
See the attached patch.
[-- Attachment #2: 0002-gnu-Depropagate-glib-from-GNOME-Shell-extensions.patch --]
[-- Type: text/x-patch, Size: 2877 bytes --]
From 8b468ac52e55560e8581a4b93ddefba00dbfab62 Mon Sep 17 00:00:00 2001
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Thu, 19 Dec 2019 13:31:58 +0100
Subject: [PATCH 2/2] gnu: Depropagate glib from GNOME Shell extensions
* gnu/packages/gnome.scm (gnome-shell-extensions): Drop propagated inputs,
move them to more appropriate place.
[propagated-inputs]: Removed field.
[native-inputs] <glib:bin>: New input.
[inputs] <glib>: New input.
* gnu/packages/gnome-xyz.scm (gnome-shell-extension-dash-to-dock): Likewise.
(gnome-shell-extension-hide-app-icon): Likewise.
---
gnu/packages/gnome-xyz.scm | 16 ++++++++--------
gnu/packages/gnome.scm | 8 ++++----
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 148f1db646..9dff38fa39 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -140,11 +140,11 @@ the Obsidian icon theme.")
(delete 'bootstrap)
(delete 'configure))))
(native-inputs
- `(("intltool" ,intltool)
+ `(("glib:bin" ,glib "bin")
+ ("intltool" ,intltool)
("pkg-config" ,pkg-config)))
- (propagated-inputs
- `(("glib" ,glib)
- ("glib" ,glib "bin")))
+ (inputs
+ `(("glib" ,glib)))
(synopsis "Transforms GNOME's dash into a dock")
(description "This extension moves the dash out of the
overview, transforming it into a dock for easier application launching and
@@ -182,12 +182,12 @@ faster window switching.")
(mkdir-p (string-append (assoc-ref outputs "out")
"/share/gnome-shell/extensions")))))))
(native-inputs
- `(("intltool" ,intltool)
+ `(("glib:bin" ,glib "bin")
+ ("intltool" ,intltool)
("unzip" ,unzip)
("zip" ,zip)))
- (propagated-inputs
- `(("glib" ,glib)
- ("glib" ,glib "bin")))
+ (inputs
+ `(("glib" ,glib)))
(synopsis "Hide app icon from GNOME's panel")
(description "This extension allows to hide the icon and/or title of the
currently focused application in the top panel of the GNOME shell.")
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 77d96987d6..117937a9ba 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7537,11 +7537,11 @@ GNOME Shell appearance and extension, etc.")
(arguments
'(#:configure-flags '("-Dextension_set=all")))
(native-inputs
- `(("intltool" ,intltool)
+ `(("glib" ,glib "bin")
+ ("intltool" ,intltool)
("pkg-config" ,pkg-config)))
- (propagated-inputs
- `(("glib" ,glib)
- ("glib" ,glib "bin")))
+ (inputs
+ `(("glib" ,glib)))
(synopsis "Extensions for GNOME Shell")
(description "GNOME Shell extensions modify and extend GNOME Shell
functionality and behavior.")
--
2.24.1
next prev parent reply other threads:[~2019-12-19 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-08 20:12 [bug#38538] [PATCH] gnu: Add gnome-shell-extension-hide-app-icon Leo Prikler
2019-12-19 9:20 ` Efraim Flashner
2019-12-19 9:22 ` Efraim Flashner
2019-12-19 11:00 ` Leo Prikler
2019-12-19 12:44 ` Leo Prikler [this message]
2019-12-19 13:38 ` Efraim Flashner
2019-12-19 14:06 ` Leo Prikler
2019-12-20 7:02 ` bug#38538: " Efraim Flashner
2019-12-22 15:33 ` [bug#38538] " Leo Prikler
2019-12-23 7:41 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15831159f236fe1a0e31d5882580c4d049a9522b.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=38538@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).