From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35020) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiCKS-0006qZ-6y for guix-patches@gnu.org; Fri, 20 Dec 2019 02:04:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiCKQ-0000nX-SN for guix-patches@gnu.org; Fri, 20 Dec 2019 02:04:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iiCKQ-0000mW-Lo for guix-patches@gnu.org; Fri, 20 Dec 2019 02:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iiCKQ-0001wo-HP for guix-patches@gnu.org; Fri, 20 Dec 2019 02:04:02 -0500 Subject: bug#38538: [PATCH] gnu: Add gnome-shell-extension-hide-app-icon Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Fri, 20 Dec 2019 09:02:42 +0200 From: Efraim Flashner Message-ID: <20191220070242.GB16523@E5400> References: <20191208201249.5479-1-leo.prikler@student.tugraz.at> <20191219092004.GE917@E5400> <15831159f236fe1a0e31d5882580c4d049a9522b.camel@student.tugraz.at> <20191219133801.GI917@E5400> <4f12bf6507870d42bd2b839e93cfc1db939d6ea8.camel@student.tugraz.at> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PmA2V3Z32TCmWXqI" Content-Disposition: inline In-Reply-To: <4f12bf6507870d42bd2b839e93cfc1db939d6ea8.camel@student.tugraz.at> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Prikler Cc: 38538-done@debbugs.gnu.org --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 19, 2019 at 03:06:27PM +0100, Leo Prikler wrote: > Am Donnerstag, den 19.12.2019, 15:38 +0200 schrieb Efraim Flashner: > > On Thu, Dec 19, 2019 at 01:44:47PM +0100, Leo Prikler wrote: > > > Am Donnerstag, den 19.12.2019, 12:00 +0100 schrieb Leo Prikler: > > > > Am Donnerstag, den 19.12.2019, 11:20 +0200 schrieb Efraim > > > > Flashner: > > > > > What does this need glib and glib:bin for? Is it just for > > > > > building > > > > > the > > > > > schemas or does it actually need it at runtime? > > > > To be honest, I'm not quite sure. I've copied this part from my > > > > dash- > > > > to-dock extension, wherein I copied it from the gnome-shell- > > > > extensions > > > > package. > > > >=20 > > > > As far as I'm aware both packages do build schemas, but I'm not > > > > sure > > > > how extensions handle them at runtime. Perhaps this is already > > > > wrong > > > > in the package I originally copied the snippet from. I'll try to > > > > see > > > > how far I can get with depropagation. > > > >=20 > > > > Regards, > > > > Leo > > > Upon closer inspection, it appears depropagation is indeed > > > possible.=20 > > > See the attached patch. > >=20 > > It makes sense to me that glib:bin should be a native-input but I > > assume > > glib, if it's needed at runtime, would probably need to be propagated > > since the extension doesn't refer to it. Likely it's getting glib > > from > > another package in the environment. > I'm not really sure, what the correct thing would be here. I did have > very weird behaviour with hide-app-icon, where having glib as input vs. > not having it made the difference of having to reload the extension > after changing settings vs. not having to. However, I'm really not > sure whether that was due to the extension or a weirdness in GNOME > Shell. >=20 In any case, I've pushed the patch with glib:bin in native-inputs and glib in propagated-inputs. > > Also, the depropagation patch should really be a separate patch for > > each > > package if we go that route. > Perhaps. I just wanted to "prove" that you can at least depropagate > glib:bin and probably glib as well. >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --PmA2V3Z32TCmWXqI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl38chIACgkQQarn3Mo9 g1GfmA/+ONnZv9+x1DAY1HecocKdLsz6KarLe5HnAhmd198JMgqGSST9G2FGLg9H dCu0dvV7Rqn/GOS5bClvmS5fV2/wd5RLGTpBRIXf+ag929OpotQ8xE60rYwKTZzv Z+s2OIEiffW8RTgFV6hgFTTtEdIADagJfUqiZ83Qdim7iHU/aNEqeVOVtS7oeDxG DaP7eveIvd/fUkhG5Pomdyy+bx1hNhceRqiyHNkD8ZfHCCOPCm/IS3mWjfIUABT6 q+Z0o5Cf3HSy7cAA+YhaLvL1sqY0FutM3C7/gBHTPFLC5ir81eYDrShH3sACOLXj hRC1EXyjWaJv/hGTYE4lyuWGmRF2YmH8lP/SqxRRHpq3k2womy+DoY7woWIk6VB+ RZD87HQzsLCkupsf8s/Mw/NSp3QSl4omizNqeBtElQ4BF0Rci9WJUMsMjNn5YbVL QKqzpD5Tp9zGWKTWbpqhVw05YP45d1qyWsdGJB8qPxWYLKewzWCuYekXu6+R+gLo H3qJSMPOlSa23BiNlJOz5pfD+UZEXflCQScY/byCsRQbplwQmXxFout2VCfF8jU0 GiS3WYb7XjGARhqebMpTEQfGNxnBajLk9bhfUKcQ2Qp8LmXikk65sKpD9UQUVfsR thyLKDqflVqfLdru3+/FSTIsoOF86MVByjvAjdQTzQqTGF31XI4= =2C7J -----END PGP SIGNATURE----- --PmA2V3Z32TCmWXqI--