From: Julien Lepiller <julien@lepiller.eu>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 36602@debbugs.gnu.org
Subject: [bug#36602] guix/build/json.scm
Date: Sun, 14 Jul 2019 14:59:45 +0200 [thread overview]
Message-ID: <20190714145945.65841b36@sybil.lepiller.eu> (raw)
In-Reply-To: <055006A2-DA0C-4570-A9D0-4A9FFD5A6037@vllmrt.net>
Le Sun, 14 Jul 2019 13:09:18 +0200,
Robert Vollmert <rob@vllmrt.net> a écrit :
> Hi,
>
> just had a look at 09a1f92f61d1ab11d2cf9f7a0983f4fc9f436f57, some
> questions:
>
> - the link to
> https://github.com/cwebber/activitystuff/blob/master/activitystuff/contrib/json.scm
> is a 404, and I can’t find (ice-9 json) elsewhere (also, shouldn’t
> cwebber be listed in the copyright line?)
> - how does this embedded json parsing module differ from (json
> parser) as used by the cargo build system? wouldn’t it be better to
> have both use the same json modules?
>
> Cheers
> Robert
>
You're right, I thought we didn't use guile-json, but since we already
use it in the cargo build system, I removed (guix build json) and fixed
the node-build-system to use (json parser) instead. I tested a few
packages, so it should be working. I pushed the changes in
8eb0ba532ebbebef23180e666e0607ea735f9c1a.
prev parent reply other threads:[~2019-07-14 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 16:46 [bug#36602] [PATCH] Add node-build-system Julien Lepiller
2019-07-11 18:25 ` Jelle Licht
2019-07-13 12:42 ` Ludovic Courtès
2019-07-13 20:20 ` Julien Lepiller
2019-07-13 21:30 ` Jelle Licht
2019-07-14 10:34 ` bug#36602: " Julien Lepiller
2019-07-14 12:46 ` [bug#36602] " swedebugia
2019-07-13 15:32 ` goodoldpaul
2019-07-14 11:09 ` [bug#36602] guix/build/json.scm Robert Vollmert
2019-07-14 12:59 ` Julien Lepiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714145945.65841b36@sybil.lepiller.eu \
--to=julien@lepiller.eu \
--cc=36602@debbugs.gnu.org \
--cc=rob@vllmrt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).