From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56772) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hme6m-0004ZA-FE for guix-patches@gnu.org; Sun, 14 Jul 2019 09:00:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hme6l-0007Qk-2A for guix-patches@gnu.org; Sun, 14 Jul 2019 09:00:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35160) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hme6k-0007QQ-UK for guix-patches@gnu.org; Sun, 14 Jul 2019 09:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hme6k-00022Q-Pm for guix-patches@gnu.org; Sun, 14 Jul 2019 09:00:02 -0400 Subject: [bug#36602] guix/build/json.scm Resent-Message-ID: Date: Sun, 14 Jul 2019 14:59:45 +0200 From: Julien Lepiller Message-ID: <20190714145945.65841b36@sybil.lepiller.eu> In-Reply-To: <055006A2-DA0C-4570-A9D0-4A9FFD5A6037@vllmrt.net> References: <20190711184653.3f6956b8@sybil.lepiller.eu> <055006A2-DA0C-4570-A9D0-4A9FFD5A6037@vllmrt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Robert Vollmert Cc: 36602@debbugs.gnu.org Le Sun, 14 Jul 2019 13:09:18 +0200, Robert Vollmert a =C3=A9crit : > Hi, >=20 > just had a look at 09a1f92f61d1ab11d2cf9f7a0983f4fc9f436f57, some > questions: >=20 > - the link to > https://github.com/cwebber/activitystuff/blob/master/activitystuff/contri= b/json.scm > is a 404, and I can=E2=80=99t find (ice-9 json) elsewhere (also, shouldn= =E2=80=99t > cwebber be listed in the copyright line?) > - how does this embedded json parsing module differ from (json > parser) as used by the cargo build system? wouldn=E2=80=99t it be better = to > have both use the same json modules? >=20 > Cheers > Robert >=20 You're right, I thought we didn't use guile-json, but since we already use it in the cargo build system, I removed (guix build json) and fixed the node-build-system to use (json parser) instead. I tested a few packages, so it should be working. I pushed the changes in 8eb0ba532ebbebef23180e666e0607ea735f9c1a.