From: Julien Lepiller <julien@lepiller.eu>
To: Jelle Licht <jlicht@fsfe.org>
Cc: 36602-done@debbugs.gnu.org
Subject: bug#36602: [PATCH] Add node-build-system.
Date: Sun, 14 Jul 2019 12:34:53 +0200 [thread overview]
Message-ID: <20190714123453.55c6d1b1@sybil.lepiller.eu> (raw)
In-Reply-To: <87a7dhsjvf.fsf@jlicht.xyz>
Le Sat, 13 Jul 2019 23:30:12 +0200,
Jelle Licht <jlicht@fsfe.org> a écrit :
> Julien Lepiller <julien@lepiller.eu> writes:
>
> > [...]
> > +(define* (install #:key outputs inputs #:allow-other-keys)
> > + "Install the node module to the output store item. MODULENAME
> > defines +under which name the module will be installed, GLOBAL?
> > determines whether this +is an npm global install."
>
> `global?' is no longer , so it could probably be removed from the
> docstring as well. LGTM otherwise :-).
I've reworked that docstring and pushed as
09a1f92f61d1ab11d2cf9f7a0983f4fc9f436f57, thank you!
next prev parent reply other threads:[~2019-07-14 10:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 16:46 [bug#36602] [PATCH] Add node-build-system Julien Lepiller
2019-07-11 18:25 ` Jelle Licht
2019-07-13 12:42 ` Ludovic Courtès
2019-07-13 20:20 ` Julien Lepiller
2019-07-13 21:30 ` Jelle Licht
2019-07-14 10:34 ` Julien Lepiller [this message]
2019-07-14 12:46 ` swedebugia
2019-07-13 15:32 ` goodoldpaul
2019-07-14 11:09 ` [bug#36602] guix/build/json.scm Robert Vollmert
2019-07-14 12:59 ` Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714123453.55c6d1b1@sybil.lepiller.eu \
--to=julien@lepiller.eu \
--cc=36602-done@debbugs.gnu.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).