[bug#36297] [PATCH] gnu: weechat: update to 2.5

[bug#36297] [PATCH] gnu: weechat: update to 2.5

[Josh Holland]

* gnu/packages/irc.scm (weechat): update to 2.5
---
 gnu/packages/irc.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/irc.scm b/gnu/packages/irc.scm
index d3b3a51294..851bea05bf 100644
--- a/gnu/packages/irc.scm
+++ b/gnu/packages/irc.scm
@@ -166,14 +166,14 @@ SILC and ICB protocols via plugins.")
 (define-public weechat
   (package
     (name "weechat")
-    (version "2.1")
+    (version "2.5")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://weechat.org/files/src/weechat-"
                                   version ".tar.xz"))
               (sha256
                (base32
-                "0f7d2vdbxc5kgjl7lkamnbxvidgxwa8f9j3nr9fd4gr4z0gzi86d"))
+                "09sc5lf7z70x3iw87q4zh8rbyngsw89pwnzs5jk195zzqdspgj2j"))
               (patches (search-patches "weechat-python.patch"))))
     (build-system cmake-build-system)
     (native-inputs
@@ -212,7 +212,7 @@ SILC and ICB protocols via plugins.")
                ((".*\\$\\{plugin.name\\} == (javascript|php|ruby)" all)
                 (string-append "// SKIP" all)))
              (substitute* "tests/scripts/test-scripts.cpp"
-               ((".*\\{ \"(jvascript|php|ruby)\", " all) ; sic
+               ((".*\\{ \"(javascript|php|ruby)\", " all)
                 (string-append "// SKIP" all)))
              #t))
          (add-after 'install 'wrap
-- 
2.22.0

[bug#36297] gnu: weechat: update to 2.5

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

Hello,

Is removing the comment intentional?

Best regards,
g_bor
-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

[-- Attachment #2: Type: text/html, Size: 360 bytes --]

[bug#36297] gnu: weechat: update to 2.5

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

Gábor,

Gábor Boskovits wrote:
> Is removing the comment intentional?

Yes.  It accompanied the deliberate ‘jvascript’ spelling, which 
has now been fixed.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[bug#36297] gnu: weechat: update to 2.5

[Josh Holland]

Hi Gábor,

On Thu, 20 Jun 2019, at 8:46 AM, Gábor Boskovits wrote:
> Is removing the comment intentional?

Yes, the "sic"[0] was indicating that the typo of "jvascript" was intended (to match an upstream typo). That's now been fixed, so the comment is no longer necessary.

Thanks,
Josh

[0]: see e.g. https://en.wikipedia.org/wiki/Sic

bug#36297: gnu: weechat: update to 2.5

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

Fixed on master on commit 9553a41dbee956aeece7631321fc52a264311541
<http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9553a41dbee956aeece7631321fc52a264311541>

Thanks for the report,

Best regards,
g_bor
-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

[-- Attachment #2: Type: text/html, Size: 499 bytes --]