From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Laura Lazzati <laura.lazzati.15@gmail.com>
Cc: "Gábor Boskovits" <boskovits@gmail.com>,
"Ricardo Wurmus" <ricardo.wurmus@mdc-berlin.de>,
33099@debbugs.gnu.org
Subject: [bug#33099] gnu: Add r-aspi.
Date: Tue, 23 Oct 2018 22:38:00 +0200 [thread overview]
Message-ID: <20181023223800.36a1522d@alma-ubu> (raw)
In-Reply-To: <CAPNLzUOrd77iucksuEqifb0S1Jb2rhGs_E1t8eb4Dqe64MNbmA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]
On Tue, 23 Oct 2018 17:04:16 -0300
Laura Lazzati <laura.lazzati.15@gmail.com> wrote:
> On Tue, Oct 23, 2018 at 4:33 PM Björn Höfling
> <bjoern.hoefling@bjoernhoefling.de> wrote:
> >
> > On Tue, 23 Oct 2018 20:29:22 +0200
> > Gábor Boskovits <boskovits@gmail.com> wrote:
> >
> > > Hello Laura,
> > >
> > > Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont:
> > > 2018. okt. 23., K, 16:48):
> > > >
> > > > On Tue, Oct 23, 2018 at 9:53 AM Björn Höfling
> > > > <bjoern.hoefling@bjoernhoefling.de> wrote:
> > >
> > > > Here goes hope the last version. When approved I have some
> > > > questions to ask :), most of them to improve future patches
> > >
> > > This patch seems to be incomplete. Most probably it is meant to be
> > > appiled on another patch. You can squash multiple commits to one,
> > > and get a single commit and
> > > a single patch.
> >
> > I case you don't know, you can use git rebase -i in order to do
> > that.
> >
> > As you have probably two linarly consequtive commits, a
> >
> > git rebase -i HEAD~2
> >
> > should do it. Read more here:
> >
> > https://git-scm.com/docs/git-rebase#_interactive_mode
> I was reading a tutorial mentioning that.
> I managed to do so, and after that made a commit --amend to adjust my
> git username - I applied the changes after the first commit.
> Thanks for answering on your holiday day :)
LGTM.
Björn
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-10-23 20:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 22:53 [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Laura Lazzati
2018-10-20 8:17 ` Ricardo Wurmus
2018-10-20 8:43 ` Gábor Boskovits
2018-10-20 11:05 ` Gábor Boskovits
2018-10-20 11:48 ` Gábor Boskovits
2018-10-20 20:28 ` Laura Lazzati
2018-10-20 21:35 ` Ricardo Wurmus
2018-10-20 22:23 ` Laura Lazzati
2018-10-21 16:52 ` Laura Lazzati
2018-10-21 21:53 ` Laura Lazzati
2018-10-22 8:46 ` Gábor Boskovits
2018-10-22 12:58 ` Laura Lazzati
2018-10-22 13:39 ` Gábor Boskovits
2018-10-22 22:29 ` Laura Lazzati
2018-10-23 7:06 ` Ricardo Wurmus
2018-10-23 7:39 ` Gábor Boskovits
2018-10-23 10:16 ` [bug#33099] gnu: Add r-aspi Laura Lazzati
2018-10-23 12:53 ` Björn Höfling
2018-10-23 14:47 ` Laura Lazzati
2018-10-23 18:29 ` Gábor Boskovits
2018-10-23 19:33 ` Björn Höfling
2018-10-23 20:04 ` Laura Lazzati
2018-10-23 20:38 ` Björn Höfling [this message]
2018-10-23 21:41 ` bug#33099: " Gábor Boskovits
2018-10-24 1:08 ` [bug#33099] " Laura Lazzati
2018-10-24 2:42 ` Björn Höfling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023223800.36a1522d@alma-ubu \
--to=bjoern.hoefling@bjoernhoefling.de \
--cc=33099@debbugs.gnu.org \
--cc=boskovits@gmail.com \
--cc=laura.lazzati.15@gmail.com \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).