On Tue, 23 Oct 2018 17:04:16 -0300 Laura Lazzati wrote: > On Tue, Oct 23, 2018 at 4:33 PM Björn Höfling > wrote: > > > > On Tue, 23 Oct 2018 20:29:22 +0200 > > Gábor Boskovits wrote: > > > > > Hello Laura, > > > > > > Laura Lazzati ezt írta (időpont: > > > 2018. okt. 23., K, 16:48): > > > > > > > > On Tue, Oct 23, 2018 at 9:53 AM Björn Höfling > > > > wrote: > > > > > > > Here goes hope the last version. When approved I have some > > > > questions to ask :), most of them to improve future patches > > > > > > This patch seems to be incomplete. Most probably it is meant to be > > > appiled on another patch. You can squash multiple commits to one, > > > and get a single commit and > > > a single patch. > > > > I case you don't know, you can use git rebase -i in order to do > > that. > > > > As you have probably two linarly consequtive commits, a > > > > git rebase -i HEAD~2 > > > > should do it. Read more here: > > > > https://git-scm.com/docs/git-rebase#_interactive_mode > I was reading a tutorial mentioning that. > I managed to do so, and after that made a commit --amend to adjust my > git username - I applied the changes after the first commit. > Thanks for answering on your holiday day :) LGTM. Björn