From: "Gábor Boskovits" <boskovits@gmail.com>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Laura Lazzati <laura.lazzati.15@gmail.com>, 33099@debbugs.gnu.org
Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file
Date: Tue, 23 Oct 2018 09:39:32 +0200 [thread overview]
Message-ID: <CAE4v=pic0umPoCszRxmP_ZZULX9JdB07z9SDiOQE-9BiA0hU+g@mail.gmail.com> (raw)
In-Reply-To: <871s8h87ms.fsf@mdc-berlin.de>
Hello Laura,
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> ezt írta (időpont: 2018.
okt. 23., K, 9:06):
>
>
> Hi Laura,
>
> > And if I don't add an eol in the description (is it there where you
> > see the line break?), after running lint command I get:
> > /home/laura/guix/gnu/packages/cran.scm:6261:2: r-aspi@0.2.0: line 6276
> > is way too long (119 characters)
>
> You should break the lines in your editor and then commit the changes
> and format the patch. The patch itself should not be modified.
>
> Gábor’s question is about the patch itself, which appears to have a line
> break in an unexpected place. This may be a result of pasting it into
> your email client. It is probably better to attach the generated file
> instead.
>
Yes, please, try to send the patch attached, I will be able to have a look
only tomorrow, because today is a national holiday in Hungary, and we
are expecting guests, but this contribution is in really good shape already.
> --
> Ricardo
g_bor
next prev parent reply other threads:[~2018-10-23 7:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 22:53 [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Laura Lazzati
2018-10-20 8:17 ` Ricardo Wurmus
2018-10-20 8:43 ` Gábor Boskovits
2018-10-20 11:05 ` Gábor Boskovits
2018-10-20 11:48 ` Gábor Boskovits
2018-10-20 20:28 ` Laura Lazzati
2018-10-20 21:35 ` Ricardo Wurmus
2018-10-20 22:23 ` Laura Lazzati
2018-10-21 16:52 ` Laura Lazzati
2018-10-21 21:53 ` Laura Lazzati
2018-10-22 8:46 ` Gábor Boskovits
2018-10-22 12:58 ` Laura Lazzati
2018-10-22 13:39 ` Gábor Boskovits
2018-10-22 22:29 ` Laura Lazzati
2018-10-23 7:06 ` Ricardo Wurmus
2018-10-23 7:39 ` Gábor Boskovits [this message]
2018-10-23 10:16 ` [bug#33099] gnu: Add r-aspi Laura Lazzati
2018-10-23 12:53 ` Björn Höfling
2018-10-23 14:47 ` Laura Lazzati
2018-10-23 18:29 ` Gábor Boskovits
2018-10-23 19:33 ` Björn Höfling
2018-10-23 20:04 ` Laura Lazzati
2018-10-23 20:38 ` Björn Höfling
2018-10-23 21:41 ` bug#33099: " Gábor Boskovits
2018-10-24 1:08 ` [bug#33099] " Laura Lazzati
2018-10-24 2:42 ` Björn Höfling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4v=pic0umPoCszRxmP_ZZULX9JdB07z9SDiOQE-9BiA0hU+g@mail.gmail.com' \
--to=boskovits@gmail.com \
--cc=33099@debbugs.gnu.org \
--cc=laura.lazzati.15@gmail.com \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).