From: Leo Famulari <leo@famulari.name>
To: "Tomáš Čech" <sleep_walker@gnu.org>
Cc: 32727@debbugs.gnu.org
Subject: [bug#32727] [PATCH] gnu: Add telegram-purple.
Date: Sat, 15 Sep 2018 20:58:15 -0400 [thread overview]
Message-ID: <20180916005815.GA4866@jasmine.lan> (raw)
In-Reply-To: <20180913122056.21012-1-sleep_walker@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]
On Thu, Sep 13, 2018 at 02:20:56PM +0200, Tomáš Čech wrote:
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/majn/telegram-purple")
> + (commit (string-append "v" version))
> + (recursive? #t)))
This recursive Git clone brings brings two libraries with it, 'tgl' and
'tl-parser':
https://github.com/majn/tgl/
https://github.com/vysheng/tl-parser
Is it possible to include these as their own separate Guix packages?
Would anything else potentially use them?
In general we try to avoid bundling things, but sometimes the effort is
not worth it.
> + `(#:tests? #f
If there are no tests, please add a comment like "No test suite". Or
else leave a comment explaining why we skip the tests.
> + (add-after 'unpack 'prepare-commit.h
> + (lambda _
> + (with-output-to-file "./commit.h"
> + (lambda ()
> + (display
> + (string-append "//generated by guix, use version instead of "
> + "commit\n"
> + "#ifndef GIT_COMMIT\n"
> + "# define GIT_COMMIT \"v"
> + ,version "\"\n"
> + "#endif\n"))))))
Can you add a brief comment explaining this?
> + (description "Telegram protocol support for pidgin.")
To make it a complete sentence, how about ""Telegram-purple is a Libpurple
protocol plugin that adds support for the Telegram messenger."?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-16 0:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 11:45 [bug#32727] [PATCH] gnu: Add telegram-purple Tomáš Čech
2018-09-13 11:49 ` Tomáš Čech
2018-09-13 12:20 ` Tomáš Čech
2018-09-16 0:58 ` Leo Famulari [this message]
2018-10-02 9:48 ` Ludovic Courtès
2018-10-21 16:18 ` Tomáš Čech
2018-10-27 14:35 ` bug#32727: " Ludovic Courtès
2018-10-27 14:57 ` [bug#32727] " Tomáš Čech
2018-10-28 22:27 ` Ludovic Courtès
2018-09-13 16:39 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180916005815.GA4866@jasmine.lan \
--to=leo@famulari.name \
--cc=32727@debbugs.gnu.org \
--cc=sleep_walker@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).