unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: "Tomáš Čech" <sleep_walker@gnu.org>
Cc: 32727-done@debbugs.gnu.org
Subject: [bug#32727] [PATCH] gnu: Add telegram-purple.
Date: Sun, 28 Oct 2018 23:27:31 +0100	[thread overview]
Message-ID: <87d0rt671o.fsf@gnu.org> (raw)
In-Reply-To: <20181027145755.GC10836@doom> ("Tomáš Čech"'s message of "Sat, 27 Oct 2018 16:57:55 +0200")

Hello!

Tomáš Čech <sleep_walker@gnu.org> skribis:

> On Sat, Oct 27, 2018 at 04:35:03PM +0200, Ludovic Courtès wrote:

[...]

>>I’ve applied this patch but I ended up making substantial changes (patch
>>attached), in particular:
>>
>>  • Arrange to run “make install” so that all the files get installed
>>    (locales, icons, etc.) and not just the .so;
>>
>>  • Adjust the test/loadtest.c so that it actually runs;
>>
>>  • Arrange to keep the standard ‘configure’ phase rather than
>>    overriding it.
>>
>>The other changes are more cosmetic.
>
> Thanks! You didn't have to do that by yourself, really. I would
> eventually made it if you wouldn't accept that.

OK, noted!  (Initially I didn’t mean to dig into it but as I was
replying I found myself effectively going deeper than expected…)

>>Are we really more picky than openSuSE?  :-)
>
> Yes, you definitely are! And it is good that way, don't lower your
> (our) standards!

Heh, thanks!

Ludo’.

  reply	other threads:[~2018-10-28 22:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 11:45 [bug#32727] [PATCH] gnu: Add telegram-purple Tomáš Čech
2018-09-13 11:49 ` Tomáš Čech
2018-09-13 12:20   ` Tomáš Čech
2018-09-16  0:58     ` Leo Famulari
2018-10-02  9:48       ` Ludovic Courtès
2018-10-21 16:18       ` Tomáš Čech
2018-10-27 14:35         ` bug#32727: " Ludovic Courtès
2018-10-27 14:57           ` [bug#32727] " Tomáš Čech
2018-10-28 22:27             ` Ludovic Courtès [this message]
2018-09-13 16:39 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0rt671o.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=32727-done@debbugs.gnu.org \
    --cc=sleep_walker@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).