From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1LP1-00087N-Tr for guix-patches@gnu.org; Sat, 15 Sep 2018 20:59:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1LOy-0003Pq-Oj for guix-patches@gnu.org; Sat, 15 Sep 2018 20:59:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37580) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g1LOy-0003PM-Ks for guix-patches@gnu.org; Sat, 15 Sep 2018 20:59:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g1LOy-0004wh-A5 for guix-patches@gnu.org; Sat, 15 Sep 2018 20:59:04 -0400 Subject: [bug#32727] [PATCH] gnu: Add telegram-purple. Resent-Message-ID: Date: Sat, 15 Sep 2018 20:58:15 -0400 From: Leo Famulari Message-ID: <20180916005815.GA4866@jasmine.lan> References: <20180913114958.14496-1-sleep_walker@gnu.org> <20180913122056.21012-1-sleep_walker@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline In-Reply-To: <20180913122056.21012-1-sleep_walker@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Cc: 32727@debbugs.gnu.org --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 13, 2018 at 02:20:56PM +0200, Tom=C3=A1=C5=A1 =C4=8Cech wrote: > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/majn/telegram-purple") > + (commit (string-append "v" version)) > + (recursive? #t))) This recursive Git clone brings brings two libraries with it, 'tgl' and 'tl-parser': https://github.com/majn/tgl/ https://github.com/vysheng/tl-parser Is it possible to include these as their own separate Guix packages? Would anything else potentially use them? In general we try to avoid bundling things, but sometimes the effort is not worth it. > + `(#:tests? #f If there are no tests, please add a comment like "No test suite". Or else leave a comment explaining why we skip the tests. > + (add-after 'unpack 'prepare-commit.h > + (lambda _ > + (with-output-to-file "./commit.h" > + (lambda () > + (display > + (string-append "//generated by guix, use version inste= ad of " > + "commit\n" > + "#ifndef GIT_COMMIT\n" > + "# define GIT_COMMIT \"v" > + ,version "\"\n" > + "#endif\n")))))) Can you add a brief comment explaining this? > + (description "Telegram protocol support for pidgin.") To make it a complete sentence, how about ""Telegram-purple is a Libpurple protocol plugin that adds support for the Telegram messenger."? --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAludqqQACgkQJkb6MLrK fwjXlQ//YRgV3afmvCCuf0Pt+6ls6HI1KIY8eupAHxOH5Nz7DQHWhS9YcFz2md+q yRlbvSZp8lKdPESqWvAIAdTUTS7b9xuIT+ab9gZt+cUtt+iIfpKrQ+W4QR1sImV/ 3463a4xknKW4+AVyVE0ibixTZXAH6Cr8/wewPrD9SRYyhpZfy1HMvPqMKN8F1XRN nJrmF557V/gr6qTZtU7XjXxM2NtUoJ1RD8bd3Zl+F0M4SHzxoIsnsB8UQ3mpzUTB nXYPTPeMtB1LS1USRmDXm4ztvp61aNL7zBLTyxqV1bUUCymwIr2jbY6fRgK/Z9A0 OumjVUVrudi++x3bZdZ6tM8RdLucAmMbf6bpX7MgjADS7cr212lhgxJSSAWglh3y e5xLqnNW0UYaI/kmR0Y1bfk186wvGANx7mQVlsJnDXNXUnoFPSuWlu/76FScdc9W LbOTLsWZi/6n7vScXQ5fGlwgtXsj9cdCAmwyzB92JiXV71pvD2USikQVUIUW23Hu SqBtmgcxEaDg2UgF/74v/ecNiQiQGZxJ04MmL9EsayHd/AuMq4R7Etb+MKZ/sJE0 CAyNdwywtqu3whNQEaVf7dGsKzgLwc1mgjtX7cXpQ5bG3nRyhTzp/dnXDe+t6dud P8FXAW/y6uG2U87/uLB/q9MUr5PMIzHubb7Wp3Z2F+NwYcUT61M= =7m4h -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR--