From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBsrm-0007YD-IT for guix-patches@gnu.org; Thu, 26 Apr 2018 22:12:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBsri-0008EV-IA for guix-patches@gnu.org; Thu, 26 Apr 2018 22:12:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:32905) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBsri-0008EA-DO for guix-patches@gnu.org; Thu, 26 Apr 2018 22:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fBsri-00089Y-3L for guix-patches@gnu.org; Thu, 26 Apr 2018 22:12:02 -0400 Subject: bug#31252: [PATCH] gnu: Add Ranger. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Thu, 26 Apr 2018 21:11:13 -0500 From: Eric Bavier Message-ID: <20180426211113.025b02cb@centurylink.net> In-Reply-To: <87po2nngbw.fsf@gnu.org> References: <1758300649.33991901.1524614953172.JavaMail.zimbra@centurylink.net> <87po2nngbw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/WD7+O/Yk89p0+SFxf0Z01hX"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 31252-done@debbugs.gnu.org --Sig_/WD7+O/Yk89p0+SFxf0Z01hX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 25 Apr 2018 23:09:39 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Eric Bavier skribis: >=20 > > + (arguments > > + '(#:phases (modify-phases %standard-phases > > + (replace 'check > > + (lambda _ (invoke "make" "test")))))) =20 >=20 > You can use #:test-target "test" instead. >=20 > > + (home-page "https://ranger.github.io/") > > + (synopsis "Console file manager") > > + (description "@code{ranger} is a console file manager with VI key = =20 >=20 > Nitpick: =E2=80=9CRanger=E2=80=9D (or =E2=80=9Cranger=E2=80=9D?) and =E2= =80=9CVi=E2=80=9D. >=20 > I haven=E2=80=99t tried using it, but otherwise LGTM. Thanks! Thanks for the review. Pushed in 834b0b9a5ca7ebd2cd3c1b2fe8dcb99e5e2f0841 and adfc742c420f34ecf925ea00d49204f9863bce33 (forgot to apply fixes before push= ing ... oops). `~Eric --Sig_/WD7+O/Yk89p0+SFxf0Z01hX Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlrihsEACgkQ/XPKxxnT JWYrpBAAhiL6ANcpHhC9nRCp4LIdB3IVF2p/hpCABRexJO5BNEFbaR+AYI1a1Hvg xFPjysW9FwjePhZCE+MRhmP1L6hTssBSnRZuLWLxnDt9hM4jHzhDzeYawLYwWjZc kZQnJ0J31xxFzIR5/FEyS4pLcDJOfFRYg5Os2Oa0a21ZvT2qhdDAV+bJrKS88fyE ldiZafCC2KCaR4HvhU0yjST651b6nfc5jTsIo4tMBecBVRwZm0WRsDgRZjEzQG29 8/wGfDQu0npe2eKs+W+MXeNRuypv2mooIiZtNWwdgZ2Oblnif44CyE/w9hsHKJrJ +ndlAYfXNLOWAZjcL0hxk62RqfRBeGHygKoDw3YuDOQ+IVwqxUUsoqwAfCKtBJwu O8Cla4YWW7/8MXmqJOtVEzuK3I4YMB5yKXCdjYvk/SoeZPWNzHpQPWSE92ScFE2u Sz+Yd5JI2hFHCqqg+orQ+0CWWlKBQyDaY9aU7t03VGOKK6xiVa1cM7b+mC4QL2EG Wz9YfEp5eOaPqdaY2DZigtt7ZsNbYc5YMTj2DY95nPQUGb/v8W4/4dfLdz+k+G2+ 2Az51LqIXj79dcCB0BH1BUzXkkgWKcqHKf9/DIw5JnXPLlDSFAinjk9MUQjl2UMd j1zUA2ZvSJug0JXnklSCoe+hwI58UGYFM7qx6Q2QPnWZ5+01VFY= =bCkd -----END PGP SIGNATURE----- --Sig_/WD7+O/Yk89p0+SFxf0Z01hX--