unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 30734@debbugs.gnu.org
Subject: [bug#30734] [PATCH core-updates 2/3] gnu: util-linux: Move '.la' files to static output.
Date: Tue, 6 Mar 2018 18:04:49 +0100	[thread overview]
Message-ID: <20180306180449.074d2365@scratchpost.org> (raw)
In-Reply-To: <20180306165642.4486-2-mbakke@fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

Hi Marius,

On Tue,  6 Mar 2018 17:56:41 +0100
Marius Bakke <mbakke@fastmail.com> wrote:

> index e63abcea4..dffe2c49c 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -608,10 +608,16 @@ providing the system administrator with some help in common tasks.")
>                         (mkdir-p (string-append static "/lib"))
>                         (with-directory-excursion out
>                           (for-each (lambda (file)
> +                                     ;; The dynamic linker does not need the '.la'
> +                                     ;; files, but libtool might.  Make sure they
> +                                     ;; refer to the right output.
> +                                     (when (string= ".la" (string-take-right file 3))

string-take-right errors out when given an argument which is longer than the length of FILE.

I suggest using (string-suffix? ".la" file) instead.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-03-06 17:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 16:54 [bug#30734] [PATCH core-updates 0/3] nologin and ifconfig profile conflicts Marius Bakke
2018-03-06 16:56 ` [bug#30734] [PATCH core-updates 1/3] gnu: util-linux: Don't build 'nologin' Marius Bakke
2018-03-06 16:56   ` [bug#30734] [PATCH core-updates 2/3] gnu: util-linux: Move '.la' files to static output Marius Bakke
2018-03-06 17:04     ` Danny Milosavljevic [this message]
2018-03-06 16:56   ` [bug#30734] [PATCH core-updates 3/3] gnu: net-tools: Don't install 'ifconfig' Marius Bakke
2018-03-06 20:20     ` Danny Milosavljevic
2018-03-07 21:19     ` Ludovic Courtès
2018-03-08 20:45       ` Marius Bakke
2018-03-08 20:53         ` Ludovic Courtès
2018-03-22 18:40           ` Marius Bakke
2018-03-23  9:22             ` Ludovic Courtès
2018-03-06 20:20   ` [bug#30734] [PATCH core-updates 1/3] gnu: util-linux: Don't build 'nologin' Danny Milosavljevic
2018-03-07 21:19   ` Ludovic Courtès
2018-08-29 21:24 ` [bug#30734] [PATCH core-updates 0/3] nologin and ifconfig profile conflicts Leo Famulari
2022-03-23 15:24 ` zimoun
2022-03-23 16:19   ` zimoun
2022-04-10 11:26     ` bug#30734: " Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306180449.074d2365@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=30734@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).