unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 30734@debbugs.gnu.org
Subject: [bug#30734] [PATCH core-updates 3/3] gnu: net-tools: Don't install 'ifconfig'.
Date: Thu, 22 Mar 2018 19:40:30 +0100	[thread overview]
Message-ID: <87d0zwkl7l.fsf@fastmail.com> (raw)
In-Reply-To: <87fu5al261.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2095 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> What about the below hack?  Alternatively, it could be moved to a
>> separate output.  Thoughts?
>>
>> From 0887b6af81781ae74f0a34c59f32ed098fa199dc Mon Sep 17 00:00:00 2001
>> From: Marius Bakke <mbakke@fastmail.com>
>> Date: Thu, 8 Mar 2018 21:41:13 +0100
>> Subject: [PATCH] gnu: net-tools: Move 'ifconfig' to "/sbin".
>>
>> * gnu/packages/linux.scm (net-tools)[arguments]: In
>> REMOVE-REDUNDANT-COMMANDS-PHASE, use rename-file on ifconfig.
>> ---
>>  gnu/packages/linux.scm | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>> index 875f11062..916309b79 100644
>> --- a/gnu/packages/linux.scm
>> +++ b/gnu/packages/linux.scm
>> @@ -1286,6 +1286,11 @@ inadequately in modern network environments, and both should be deprecated.")
>>                                         '("^hostname"
>>                                           "^(yp|nis|dns)?domainname"))))
>>                   (for-each delete-file dup)
>> +                 ;; ifconfig from net-tools is somewhat incompatible with
>> +                 ;; GNU ifconfig, so we keep it around.  Move it to "/sbin"
>> +                 ;; to prevent conflict in %base-packages.
>> +                 (rename-file (string-append out "/bin/ifconfig")
>> +                              (string-append out "/sbin/ifconfig"))
>>                   #t))))
>
> Sure, either that or rename it to “ifconfig.net-tools” (I think Debian
> sometimes does things like this.)
>
> But, isc-dhcp depends on net-tools, and it might have scripts that
> depend on its ifconfig, for instance.  Same for virtuoso-ose, isc-bind,
> iodine, and more.
>
> So all in all, your suggestion may be safer, though we should check
> whether these things break.

I like renaming it better than moving to 'sbin'.  I'll try out some of
the dependent packages and see what needs to be done.  Would it be okay
to switch to GNU Inetutils for those that require 'ifconfig'?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2018-03-22 18:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 16:54 [bug#30734] [PATCH core-updates 0/3] nologin and ifconfig profile conflicts Marius Bakke
2018-03-06 16:56 ` [bug#30734] [PATCH core-updates 1/3] gnu: util-linux: Don't build 'nologin' Marius Bakke
2018-03-06 16:56   ` [bug#30734] [PATCH core-updates 2/3] gnu: util-linux: Move '.la' files to static output Marius Bakke
2018-03-06 17:04     ` Danny Milosavljevic
2018-03-06 16:56   ` [bug#30734] [PATCH core-updates 3/3] gnu: net-tools: Don't install 'ifconfig' Marius Bakke
2018-03-06 20:20     ` Danny Milosavljevic
2018-03-07 21:19     ` Ludovic Courtès
2018-03-08 20:45       ` Marius Bakke
2018-03-08 20:53         ` Ludovic Courtès
2018-03-22 18:40           ` Marius Bakke [this message]
2018-03-23  9:22             ` Ludovic Courtès
2018-03-06 20:20   ` [bug#30734] [PATCH core-updates 1/3] gnu: util-linux: Don't build 'nologin' Danny Milosavljevic
2018-03-07 21:19   ` Ludovic Courtès
2018-08-29 21:24 ` [bug#30734] [PATCH core-updates 0/3] nologin and ifconfig profile conflicts Leo Famulari
2022-03-23 15:24 ` zimoun
2022-03-23 16:19   ` zimoun
2022-04-10 11:26     ` bug#30734: " Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0zwkl7l.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=30734@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).