From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etG1R-0003HG-UE for guix-patches@gnu.org; Tue, 06 Mar 2018 12:05:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etG1O-0006UJ-NV for guix-patches@gnu.org; Tue, 06 Mar 2018 12:05:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:40075) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etG1O-0006UD-Is for guix-patches@gnu.org; Tue, 06 Mar 2018 12:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1etG1O-0005ke-AG for guix-patches@gnu.org; Tue, 06 Mar 2018 12:05:02 -0500 Subject: [bug#30734] [PATCH core-updates 2/3] gnu: util-linux: Move '.la' files to static output. Resent-Message-ID: Date: Tue, 6 Mar 2018 18:04:49 +0100 From: Danny Milosavljevic Message-ID: <20180306180449.074d2365@scratchpost.org> In-Reply-To: <20180306165642.4486-2-mbakke@fastmail.com> References: <20180306165642.4486-1-mbakke@fastmail.com> <20180306165642.4486-2-mbakke@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/Jqe3O4yPBV_1g=a3Y7FJY=g"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 30734@debbugs.gnu.org --Sig_/Jqe3O4yPBV_1g=a3Y7FJY=g Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Marius, On Tue, 6 Mar 2018 17:56:41 +0100 Marius Bakke wrote: > index e63abcea4..dffe2c49c 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -608,10 +608,16 @@ providing the system administrator with some help i= n common tasks.") > (mkdir-p (string-append static "/lib")) > (with-directory-excursion out > (for-each (lambda (file) > + ;; The dynamic linker does not need= the '.la' > + ;; files, but libtool might. Make = sure they > + ;; refer to the right output. > + (when (string=3D ".la" (string-take= -right file 3)) string-take-right errors out when given an argument which is longer than th= e length of FILE. I suggest using (string-suffix? ".la" file) instead. --Sig_/Jqe3O4yPBV_1g=a3Y7FJY=g Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlqeyjEACgkQ5xo1VCww uqUgKQf/fO895XT2xesC88wJBkFbSW9A4u/ir66tFK1o0ci50BCJhRLN2LDU41oG NVrhBy6lz6NBcZ06jrXtH7N9I9nu0FJxILyZwbaP4u+lizDVPQP1BS3uZbEROyPa sdDhlhM626sV/BcbgObCJCF/5KPPQ8wy35VxA02cOHiMTnm630Qlho9Ix0LNoHiI n6+UL7kAceiGaazkYwKTmtcBcIP975lBWGj77A+VZjRSysYEcrW96FUvlLHvCgJR qkQ92chTZipySe9T+vMui2PCJJl3p5B3miKhpXQALaLOxbFiXyO2VqQBMxzAoU2O zVwYyH7abQYnENgpNQH72N9trrk4dw== =ihtu -----END PGP SIGNATURE----- --Sig_/Jqe3O4yPBV_1g=a3Y7FJY=g--