* [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library.
@ 2018-02-18 19:50 Kei Kebreau
2018-02-18 20:22 ` Kei Kebreau
2018-03-07 13:04 ` Ludovic Courtès
0 siblings, 2 replies; 4+ messages in thread
From: Kei Kebreau @ 2018-02-18 19:50 UTC (permalink / raw)
To: 30517; +Cc: Kei Kebreau
* gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
flag.
---
gnu/packages/music.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 3709f10d1..e88c9f21f 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
(("add_subdirectory\\(resources/music\\)") ""))))))
(build-system cmake-build-system)
(arguments
- '(#:tests? #f)) ; no check target
+ '(#:tests? #f ; no check target
+ #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
(inputs
`(("alsa-lib" ,alsa-lib)
("jack" ,jack-1)
--
2.16.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library.
2018-02-18 19:50 [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library Kei Kebreau
@ 2018-02-18 20:22 ` Kei Kebreau
2018-03-07 13:04 ` Ludovic Courtès
1 sibling, 0 replies; 4+ messages in thread
From: Kei Kebreau @ 2018-02-18 20:22 UTC (permalink / raw)
To: 30517
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
Kei Kebreau <kkebreau@posteo.net> writes:
> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
> flag.
> ---
> gnu/packages/music.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 3709f10d1..e88c9f21f 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
> (("add_subdirectory\\(resources/music\\)") ""))))))
> (build-system cmake-build-system)
> (arguments
> - '(#:tests? #f)) ; no check target
> + '(#:tests? #f ; no check target
> + #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
> (inputs
> `(("alsa-lib" ,alsa-lib)
> ("jack" ,jack-1)
It should be noted that when I configure MilkyTracker to use JACK as an
audio driver, close the program, start the JACK server and open
MilkyTracker again, the MilkyTracker window appears black. When I drag
the window around on my desktop the program graphics flicker until I
stop dragging it, at which point it goes black again. Does anyone else
get this bug?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library.
2018-02-18 19:50 [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library Kei Kebreau
2018-02-18 20:22 ` Kei Kebreau
@ 2018-03-07 13:04 ` Ludovic Courtès
2018-03-08 15:11 ` bug#30517: " Kei Kebreau
1 sibling, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2018-03-07 13:04 UTC (permalink / raw)
To: Kei Kebreau; +Cc: 30517
Kei Kebreau <kkebreau@posteo.net> skribis:
> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
> flag.
> ---
> gnu/packages/music.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 3709f10d1..e88c9f21f 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
> (("add_subdirectory\\(resources/music\\)") ""))))))
> (build-system cmake-build-system)
> (arguments
> - '(#:tests? #f)) ; no check target
> + '(#:tests? #f ; no check target
> + #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
I’d suggest adding a comment as to why this is needed.
Then I think you can go ahead and push it. If it fixes a use case for
you, that’s already an improvement.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#30517: [PATCH] gnu: milkytracker: Actually link with the JACK library.
2018-03-07 13:04 ` Ludovic Courtès
@ 2018-03-08 15:11 ` Kei Kebreau
0 siblings, 0 replies; 4+ messages in thread
From: Kei Kebreau @ 2018-03-08 15:11 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 30517-done
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
ludo@gnu.org (Ludovic Courtès) writes:
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
>> flag.
>> ---
>> gnu/packages/music.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>> index 3709f10d1..e88c9f21f 100644
>> --- a/gnu/packages/music.scm
>> +++ b/gnu/packages/music.scm
>> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
>> (("add_subdirectory\\(resources/music\\)") ""))))))
>> (build-system cmake-build-system)
>> (arguments
>> - '(#:tests? #f)) ; no check target
>> + '(#:tests? #f ; no check target
>> + #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
>
> I’d suggest adding a comment as to why this is needed.
>
> Then I think you can go ahead and push it. If it fixes a use case for
> you, that’s already an improvement.
>
> Thanks,
> Ludo’.
Pushed with added comment. Thanks for reviewing!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-08 15:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-18 19:50 [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library Kei Kebreau
2018-02-18 20:22 ` Kei Kebreau
2018-03-07 13:04 ` Ludovic Courtès
2018-03-08 15:11 ` bug#30517: " Kei Kebreau
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).