From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etxEB-00076r-0Q for guix-patches@gnu.org; Thu, 08 Mar 2018 10:13:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etxE7-0005ns-Od for guix-patches@gnu.org; Thu, 08 Mar 2018 10:13:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etxE7-0005nf-KG for guix-patches@gnu.org; Thu, 08 Mar 2018 10:13:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1etxE7-0001o7-7m for guix-patches@gnu.org; Thu, 08 Mar 2018 10:13:03 -0500 Subject: bug#30517: [PATCH] gnu: milkytracker: Actually link with the JACK library. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Kei Kebreau References: <20180218195049.20339-1-kkebreau@posteo.net> <87y3j4rq8u.fsf@gnu.org> Date: Thu, 08 Mar 2018 10:11:55 -0500 In-Reply-To: <87y3j4rq8u.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 07 Mar 2018 14:04:33 +0100") Message-ID: <874llqlhz8.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30517-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Kei Kebreau skribis: > >> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate conf= igure >> flag. >> --- >> gnu/packages/music.scm | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm >> index 3709f10d1..e88c9f21f 100644 >> --- a/gnu/packages/music.scm >> +++ b/gnu/packages/music.scm >> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music= .") >> (("add_subdirectory\\(resources/music\\)") "")))))) >> (build-system cmake-build-system) >> (arguments >> - '(#:tests? #f)) ; no check target >> + '(#:tests? #f ; no check target >> + #:configure-flags '("-DCMAKE_CXX_FLAGS=3D-ljack"))) > > I=E2=80=99d suggest adding a comment as to why this is needed. > > Then I think you can go ahead and push it. If it fixes a use case for > you, that=E2=80=99s already an improvement. > > Thanks, > Ludo=E2=80=99. Pushed with added comment. Thanks for reviewing! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlqhUrsACgkQ5qXuPBlG eg01qg/+Oi0Z81aF2akjYTkUDYJ3nGTWxfk5nraV09w3nZ0vLkbQehO7ElHrt8aT +q5V96nJDdnEkxVk+prCHP2B6vZHpkfDb5Kol4kBND4uoYoZmfxLRjs4mgUw2Et1 zPpwdSGZMIAC5k2z26XEifnPdgVNeorbx5VNlq26n1At4j0DPpjqsA5hjCJavH1L rjacg34an81dTMJv184+t82g0AmashOibjZ5SGSS/b/Vv7DbMkD5hObmtHaCvHNk iFiUxwvD71lqVqBUVWeAIYJz5PSH0AB/vzVvAoz8tXwKVfBWhJr5b7xp9qPKFrmX roHTjdK6ECWnVC3sZCQuBqGvY6e3w0dVA78zyiEx7pTUy9ieOtEa4sDSbnhssfHq XSb8a7u4W8+IDpL/81hJjeyroJ3EBOk1gSjV+AfvFPudU8sxPAQUa7XbS6F2HHLu tEwbydn4Tms4KXEzouxn7CVCnoBcbeH2TrQoSeSAVWO2NlBUdwMZlymGHjczWW1G o35hCm4cYrO01uX4A+3f27PQ4rsdsbS56Dokii8/uToSRxxrvOZidOnjX7cOChL0 qecWGAZLCNYJfVlhlKWr1U5RrAFax4ZGE257fAj1y9gpa1Sbt5LGstzf/+bfzKhZ aqcVGtrjChcUgi4V5X9yLp7Hk+uZnqeKbpOytv82JivGAjPa8HA= =KF07 -----END PGP SIGNATURE----- --=-=-=--