From: Leo Famulari <leo@famulari.name>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 29392@debbugs.gnu.org
Subject: [bug#29392] [PATCH 02/11] build-system: Add scons-build-system.
Date: Sun, 26 Nov 2017 16:04:12 -0500 [thread overview]
Message-ID: <20171126210412.GB6880@jasmine.lan> (raw)
In-Reply-To: <20171122093507.6827-2-arunisaac@systemreboot.net>
[-- Attachment #1: Type: text/plain, Size: 2797 bytes --]
On Wed, Nov 22, 2017 at 03:04:58PM +0530, Arun Isaac wrote:
> * guix/build-system/scons.scm: New file.
> * guix/build/scons-build-system.scm: New file.
> * Makefile.am (MODULES): Register them.
> * doc/guix.texi (Build Systems): Add scons-build-system.
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -42,6 +42,7 @@ Copyright @copyright{} 2017 Hartmut Goebel@*
> Copyright @copyright{} 2017 Maxim Cournoyer@*
> Copyright @copyright{} 2017 Tobias Geerinckx-Rice@*
> Copyright @copyright{} 2017 George Clemmer
> +Copyright @copyright{} 2017 Arun Isaac
Make sure to add a line break (@*) after George's name.
https://www.gnu.org/software/texinfo/manual/texinfo/html_node/Line-Breaks.html
> +@defvr {Scheme Variable} scons-build-system
> +This variable is exported by @code{(guix build-system scons)}. It
> +implements the build procedure used by the @code{scons} software
Here we are not referring to SCons itself, but not a code variable. So,
I think we can skip using @code here.
> +construction tool. This build system runs @code{scons} to build the
> +package, @code{scons test} to run tests, and then @code{scons install}
> +to install the package. Additional flags to be passed to @code{scons}
^
Same here ---------------------------------------------------|
> diff --git a/guix/build-system/scons.scm b/guix/build-system/scons.scm
[...]
> +;; Standard build procedure for applications using 'scons'. This is
I would say SCons instead of 'scons', and anywhere we refer to SCons as
a project rather than a particular program. This is mostly in the
manual, comments, docstrings, etc.
> + (build-inputs `(("scons-python2" ,(module-ref (resolve-interface '(gnu packages python)) 'scons-python2))
> + ,@native-inputs))
Is there a particular reason we use a Python 2 variant of SCons? If so,
can you explain it in a code comment?
> +(define* (scons-build store name inputs
> + #:key
> + (tests? #t)
> + (scons-flags ''())
> + (test-target "test")
> + (phases '(@ (guix build scons-build-system)
> + %standard-phases))
> + (outputs '("out"))
> + (search-paths '())
> + (system (%current-system))
> + (guile #f)
> + (imported-modules %scons-build-system-modules)
> + (modules '((guix build scons-build-system)
> + (guix build utils))))
> + "Build SOURCE using SCONS, and with INPUTS. This assumes that SOURCE
There isn't a variable named 'scons' here, so I think it would be
SCONS-PYTHON2.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-26 21:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 8:41 [bug#29392] [PATCH 00/11] New scons build system Arun Isaac
2017-11-22 9:34 ` [bug#29392] [PATCH 01/11] gnu: scons: Update to 3.0.1 Arun Isaac
2017-11-22 9:34 ` [bug#29392] [PATCH 02/11] build-system: Add scons-build-system Arun Isaac
2017-11-26 21:04 ` Leo Famulari [this message]
2017-11-22 9:34 ` [bug#29392] [PATCH 03/11] gnu: linuxdcpp: Use scons-build-system Arun Isaac
2017-11-22 9:35 ` [bug#29392] [PATCH 04/11] gnu: gpick: " Arun Isaac
2017-11-22 9:35 ` [bug#29392] [PATCH 05/11] gnu: serf: " Arun Isaac
2017-11-22 9:35 ` [bug#29392] [PATCH 06/11] gnu: metabat: " Arun Isaac
2017-11-22 9:35 ` [bug#29392] [PATCH 07/11] gnu: godot: " Arun Isaac
2017-11-22 9:35 ` [bug#29392] [PATCH 08/11] gnu: pingus: " Arun Isaac
2017-11-22 9:35 ` [bug#29392] [PATCH 09/11] gnu: klick: " Arun Isaac
2017-11-22 9:35 ` [bug#29392] [PATCH 10/11] gnu: mongodb: " Arun Isaac
2017-11-22 9:35 ` [bug#29392] [PATCH 11/11] gnu: pingus: Use HTTPS for home page Arun Isaac
2017-11-25 16:04 ` [bug#29392] [PATCH 00/11] New scons build system Leo Famulari
2017-11-25 16:05 ` Leo Famulari
2017-11-26 11:17 ` Arun Isaac
2017-11-26 1:26 ` Leo Famulari
2017-11-26 16:17 ` Ludovic Courtès
2017-11-26 18:51 ` Leo Famulari
2017-11-28 17:06 ` [bug#29392] [PATCH 00/11] Add " Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 01/11] gnu: scons: Update to 3.0.1 Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 02/11] build-system: Add scons-build-system Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 03/11] gnu: linuxdcpp: Use scons-build-system Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 04/11] gnu: gpick: " Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 05/11] gnu: serf: " Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 06/11] gnu: metabat: " Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 07/11] gnu: godot: " Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 08/11] gnu: pingus: " Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 09/11] gnu: klick: " Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 10/11] gnu: mongodb: " Arun Isaac
2017-11-28 17:06 ` [bug#29392] [PATCH 11/11] gnu: pingus: Use HTTPS for home page Arun Isaac
2017-11-28 21:38 ` [bug#29392] [PATCH 00/11] Add scons build system Leo Famulari
2017-11-29 8:19 ` Arun Isaac
2017-11-29 21:29 ` Leo Famulari
2017-11-30 13:40 ` bug#29392: " Arun Isaac
2017-11-30 17:05 ` [bug#29392] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171126210412.GB6880@jasmine.lan \
--to=leo@famulari.name \
--cc=29392@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).