From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJ46u-0003rJ-J0 for guix-patches@gnu.org; Sun, 26 Nov 2017 16:05:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJ46p-0005pY-TS for guix-patches@gnu.org; Sun, 26 Nov 2017 16:05:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:50997) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJ46p-0005ow-Fg for guix-patches@gnu.org; Sun, 26 Nov 2017 16:05:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJ46n-0005qm-Mn for guix-patches@gnu.org; Sun, 26 Nov 2017 16:05:03 -0500 Subject: [bug#29392] [PATCH 02/11] build-system: Add scons-build-system. Resent-Message-ID: Date: Sun, 26 Nov 2017 16:04:12 -0500 From: Leo Famulari Message-ID: <20171126210412.GB6880@jasmine.lan> References: <20171122093507.6827-1-arunisaac@systemreboot.net> <20171122093507.6827-2-arunisaac@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4bRzO86E/ozDv8r1" Content-Disposition: inline In-Reply-To: <20171122093507.6827-2-arunisaac@systemreboot.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 29392@debbugs.gnu.org --4bRzO86E/ozDv8r1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 22, 2017 at 03:04:58PM +0530, Arun Isaac wrote: > * guix/build-system/scons.scm: New file. > * guix/build/scons-build-system.scm: New file. > * Makefile.am (MODULES): Register them. > * doc/guix.texi (Build Systems): Add scons-build-system. > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -42,6 +42,7 @@ Copyright @copyright{} 2017 Hartmut Goebel@* > Copyright @copyright{} 2017 Maxim Cournoyer@* > Copyright @copyright{} 2017 Tobias Geerinckx-Rice@* > Copyright @copyright{} 2017 George Clemmer > +Copyright @copyright{} 2017 Arun Isaac Make sure to add a line break (@*) after George's name. https://www.gnu.org/software/texinfo/manual/texinfo/html_node/Line-Breaks.html > +@defvr {Scheme Variable} scons-build-system > +This variable is exported by @code{(guix build-system scons)}. It > +implements the build procedure used by the @code{scons} software Here we are not referring to SCons itself, but not a code variable. So, I think we can skip using @code here. > +construction tool. This build system runs @code{scons} to build the > +package, @code{scons test} to run tests, and then @code{scons install} > +to install the package. Additional flags to be passed to @code{scons} ^ Same here ---------------------------------------------------| > diff --git a/guix/build-system/scons.scm b/guix/build-system/scons.scm [...] > +;; Standard build procedure for applications using 'scons'. This is I would say SCons instead of 'scons', and anywhere we refer to SCons as a project rather than a particular program. This is mostly in the manual, comments, docstrings, etc. > + (build-inputs `(("scons-python2" ,(module-ref (resolve-interface '(gnu packages python)) 'scons-python2)) > + ,@native-inputs)) Is there a particular reason we use a Python 2 variant of SCons? If so, can you explain it in a code comment? > +(define* (scons-build store name inputs > + #:key > + (tests? #t) > + (scons-flags ''()) > + (test-target "test") > + (phases '(@ (guix build scons-build-system) > + %standard-phases)) > + (outputs '("out")) > + (search-paths '()) > + (system (%current-system)) > + (guile #f) > + (imported-modules %scons-build-system-modules) > + (modules '((guix build scons-build-system) > + (guix build utils)))) > + "Build SOURCE using SCONS, and with INPUTS. This assumes that SOURCE There isn't a variable named 'scons' here, so I think it would be SCONS-PYTHON2. --4bRzO86E/ozDv8r1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlobLEwACgkQJkb6MLrK fwhtyA//f256LcW4Ol8TfINqTZQGVGsA2fzRQMRl+x9pOzWN7kf3hKaPniS1MkAS LRFla4XRhESgrXcoZvKKLQafMXMOx5xN0xqfEQoXXmZSfnM1iGdCRlYlLBxPA5Q6 NQW3QXlt1KJ3IMF/39i25Mv3jMg3VX8RnEIXti9oHzbKbP9JnY3GX1C63NCaSUy7 FofNZoG5N7Wm2KTHpNqGbSf9MxxIN9gISXtzcdaT7VVPdWHzbOepAUc3gYRThfiM SRE1o2M5v6LLDHGW47zQlurwVED/CdSiR3wLs+5gJVrTp47HWkaENlTAr2h8rjwr XbPijcTiCYg+rchXoMIUe6NGA6fKv0ihagVSvHZpRuyzgt90BwBHIXLguy2bnz+s t6CVf/1cvbEi7zcjov6R8FBfHvsgsb+qeOhbbdybgs1dwbotGbiyy5x70OPcaZHC +twDWBrXHOhU77PmC0tf5L/AEpv4U1NhuswAOxrorl2ZLI355Uc8XKKqIQDPYCJq ATwce4MLhBLAaeXW7RFsAGmLOu7HaP1WLZolKrqq5r5K75TbUz1P9dbqZ+6murHM lwxTi5gwaGnQQ18krn4STY83PxYkmBWcB/Js6Pha6N0Ic89ZVnr9+fTzIePzai9i WGZtXQLoIexoE+M5aV3BW8VH5W4thKTIPdE47sC034B3shp60Nw= =ec7y -----END PGP SIGNATURE----- --4bRzO86E/ozDv8r1--