From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyD49-00069p-OA for guix-patches@gnu.org; Sat, 30 Sep 2017 04:24:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyD46-0001Xx-KD for guix-patches@gnu.org; Sat, 30 Sep 2017 04:24:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59551) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyD46-0001Xo-Ge for guix-patches@gnu.org; Sat, 30 Sep 2017 04:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyD46-0000nF-7h for guix-patches@gnu.org; Sat, 30 Sep 2017 04:24:02 -0400 Subject: [bug#28583] [PATCH 4/7] gnu: Add ruby-highline. Resent-Message-ID: Date: Sat, 30 Sep 2017 09:23:07 +0100 From: Christopher Baines Message-ID: <20170930092307.0b8e7858@cbaines.net> In-Reply-To: <6aeccdcc-1509-6440-7ee8-1ca4fc7615e8@uq.edu.au> References: <20170924171717.3855-1-mail@cbaines.net> <20170924171717.3855-4-mail@cbaines.net> <6aeccdcc-1509-6440-7ee8-1ca4fc7615e8@uq.edu.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/_zv9Q9jF8aLOO7h4X9idQ8Q"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ben Woodcroft Cc: 28583@debbugs.gnu.org --Sig_/_zv9Q9jF8aLOO7h4X9idQ8Q Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 27 Sep 2017 22:37:39 +1000 Ben Woodcroft wrote: > On 25/09/17 03:17, Christopher Baines wrote: > > * gnu/packages/ruby.scm (ruby-highline): New variable. > > --- > > gnu/packages/ruby.scm | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > > index 1ee03e066..9863d4b37 100644 > > --- a/gnu/packages/ruby.scm > > +++ b/gnu/packages/ruby.scm > > @@ -216,6 +216,33 @@ a focus on simplicity and productivity.") > > (("/bin/sh") (which "sh")))) > > %standard-phases))))) > > =20 > > +(define-public ruby-highline > > + (package > > + (name "ruby-highline") > > + (version "1.7.8") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (rubygems-uri "highline" version)) > > + (sha256 > > + (base32 > > + "1nf5lgdn6ni2lpfdn4gk3gi47fmnca2bdirabbjbz1fk9w4p8lkr")))) > > + (build-system ruby-build-system) > > + (arguments > > + `(#:tests? #f)) ;; TODO: Requires code_statistics =20 > I've attached a package for code_statistics, but adding it does not > help because there appears to be something amiss in the Rakefile. > This has been fixed in the not quite released 2.0.0 version, so the > patch may be useful in future. Awesome, thanks Ben. I've send an updated set of patches, including this one now. It looks good to me. > > + (native-inputs > > + `(("bundler" ,bundler))) > > + (synopsis > > + "HighLine helps you build command-line interfaces") > > + (description > > + "HighLine provides a high-level IO library that provides > > validation, +type conversion, and more for command-line interfaces. > > + > > +HighLine also includes a menu system for providing multiple > > options to the +user.") =20 > I would combine the two sentences into one paragraph. I've made this change in the updated patches. > Otherwise LGTM. >=20 --Sig_/_zv9Q9jF8aLOO7h4X9idQ8Q Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPVGtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xc0CQ/9EgzsYF3uNQzK29aN4der6WlvUhnuWxmBDeltymc/CinqgC+fYxsp5MIi ALpIm9zkJkBSxtmVeNwhgPIf5hHLMCvVud3Az/YdoS2NsWV95z59mBNzsFrTy76i zvRPwWgglDcJB8u0JbKZ0VDSnbj5hyQCBX9OapZdI9kXEXCNMr8F9DwBUkZoCmxW 97fQECjQjBcH8/pMaqxXMuJ7hMctGH1eGIGswBFxVvX1IV0ZpJ5SJGbwOq9YXDIZ W8wZWMcoPf/DgHAb64Q83Kr0DS8IriVHSIQw7yK34odkG+rgStJWix34gFvnTZl9 EQ3IaREOjnyOkocjYTO2XodqfffrITHMtuk6T1wqjTdbINs2Gr8HjYCc1usfjDtC KciE7/4IyaVmzW0MeoKsx/a3hGVrmisZSKw9LAM6Vaovy5nXcvD3p7Zy6N6qF3GQ RyUYt1I+ZNp+p04Nyv4tFT/IH6n1ipLddxeS8W4yH9qn27uF4UB+fGaHbKUvaMOa Pb1IZ4jigg/OzuuEt30MaXxsWSU9j2f3AZA9AA1A0PsjPoNYtIEg26N6myPT++WS a+1TqG82qUrR6+CZ+B0OpfMbzHYjc9Thm35FNNTwzDV7kMiHmHNZMSLCHsT0Soyc 3HwYDey05TAiKfNzHb/SGs9endFwEodaTEN3kk/wmlQZL5MgUHI= =36xi -----END PGP SIGNATURE----- --Sig_/_zv9Q9jF8aLOO7h4X9idQ8Q--