* [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
@ 2023-12-19 14:19 peter
2023-12-25 16:40 ` Mathieu Othacehe
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: peter @ 2023-12-19 14:19 UTC (permalink / raw)
To: 67905
Cc: Peter Polidoro, Andrew Tropin, Katherine Cox-Buday,
Liliana Marie Prikler
From: Peter Polidoro <peter@polidoro.io>
* gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.
Change-Id: I34fe0c67e8776083a9ae448d834eed8f4105d176
---
gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f8bd9a111e..e452e88283 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1374,6 +1374,27 @@ (define-public emacs-project-mode-line-tag
its mode line.")
(license license:gpl3+))))
+(define-public emacs-golden-ratio
+ (package
+ (name "emacs-golden-ratio")
+ (version "20230912.1825")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/roman/golden-ratio.el.git")
+ (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))
+ (sha256
+ (base32 "0a635a3h6jx0clgwmhwc48i14y3xy5q29y37lp2sjnbxx1hlmkli"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/roman/golden-ratio.el")
+ (synopsis "Automatic resizing of Emacs windows to the golden ratio")
+ (description "This package provides an Emacs mode for automatically
+resizing the window that has main focus to be more convenient for editing,
+while the ones that are not being actively edited will be reduced to a smaller
+size.")
+ (license license:expat)))
+
(define-public emacs-git-modes
(package
(name "emacs-git-modes")
base-commit: ee93015b54a2abfe59bc2270c09ea4f7624488e5
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
2023-12-19 14:19 [bug#67905] [PATCH] gnu: Add emacs-golden-ratio peter
@ 2023-12-25 16:40 ` Mathieu Othacehe
2024-01-03 19:48 ` peter
2024-01-04 14:16 ` peter
2 siblings, 0 replies; 6+ messages in thread
From: Mathieu Othacehe @ 2023-12-25 16:40 UTC (permalink / raw)
To: peter; +Cc: Katherine Cox-Buday, 67905, Liliana Marie Prikler, Andrew Tropin
Hello,
There are two linter warnings here:
--8<---------------cut here---------------start------------->8---
/home/mathieu/guix/gnu/packages/emacs-xyz.scm:1382:5:
emacs-golden-ratio@20230912.1825: the source file name should contain
the package name
/home/mathieu/guix/gnu/packages/emacs-xyz.scm:1382:5:
emacs-golden-ratio@20230912.1825: permanent redirect from
https://github.com/roman/golden-ratio.el.git to
https://github.com/roman/golden-ratio.el
--8<---------------cut here---------------end--------------->8---
> + (uri (git-reference
> + (url "https://github.com/roman/golden-ratio.el.git")
> + (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))
The first one can probably be resolved by adding the following line
here:
(file-name (git-file-name name version))
> + (sha256
> + (base32 "0a635a3h6jx0clgwmhwc48i14y3xy5q29y37lp2sjnbxx1hlmkli"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/roman/golden-ratio.el")
And the second one by updating this URL.
Could you please send an updated patch?
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
2023-12-19 14:19 [bug#67905] [PATCH] gnu: Add emacs-golden-ratio peter
2023-12-25 16:40 ` Mathieu Othacehe
@ 2024-01-03 19:48 ` peter
2024-01-04 10:28 ` Nicolas Goaziou via Guix-patches via
2024-01-04 14:16 ` peter
2 siblings, 1 reply; 6+ messages in thread
From: peter @ 2024-01-03 19:48 UTC (permalink / raw)
To: 67905
Cc: Peter Polidoro, Andrew Tropin, Katherine Cox-Buday,
Liliana Marie Prikler
From: Peter Polidoro <peter@polidoro.io>
* gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.
Change-Id: I44de02989b8dadd4a395374fe078d4255a210028
---
gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb3c905252..3937e209b8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1374,6 +1374,28 @@ (define-public emacs-project-mode-line-tag
its mode line.")
(license license:gpl3+))))
+(define-public emacs-golden-ratio
+ (package
+ (name "emacs-golden-ratio")
+ (version "20230912.1825")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/roman/golden-ratio.el")
+ (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0a635a3h6jx0clgwmhwc48i14y3xy5q29y37lp2sjnbxx1hlmkli"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/roman/golden-ratio.el")
+ (synopsis "Automatic resizing of Emacs windows to the golden ratio")
+ (description "This package provides an Emacs mode for automatically
+resizing the window that has main focus to be more convenient for editing,
+while the ones that are not being actively edited will be reduced to a smaller
+size.")
+ (license license:expat)))
+
(define-public emacs-git-modes
(package
(name "emacs-git-modes")
base-commit: 2f642b602398ab32b18faceecd074f49da92e95e
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
2024-01-03 19:48 ` peter
@ 2024-01-04 10:28 ` Nicolas Goaziou via Guix-patches via
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-01-04 10:28 UTC (permalink / raw)
To: peter; +Cc: Katherine Cox-Buday, 67905, Liliana Marie Prikler, Andrew Tropin
Hello,
peter@polidoro.io writes:
> From: Peter Polidoro <peter@polidoro.io>
>
> * gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.
Thank you.
> +(define-public emacs-golden-ratio
> + (package
> + (name "emacs-golden-ratio")
> + (version "20230912.1825")
The version is "1.0.1", plus a few commits. Therefore, the line above
should be:
(version (git-version "1.0.1" revision commit))
where `revision' is bound to "1" (or "0", it all depends on your
beliefs), and `commit' to "375c9f287dfad68829582c1e0a67d0c18119dab9".
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/roman/golden-ratio.el")
> + (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))
Per above, this should be bound to `revision'
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
2023-12-19 14:19 [bug#67905] [PATCH] gnu: Add emacs-golden-ratio peter
2023-12-25 16:40 ` Mathieu Othacehe
2024-01-03 19:48 ` peter
@ 2024-01-04 14:16 ` peter
2024-01-21 23:29 ` bug#67905: " Nicolas Goaziou via Guix-patches via
2 siblings, 1 reply; 6+ messages in thread
From: peter @ 2024-01-04 14:16 UTC (permalink / raw)
To: 67905
Cc: Peter Polidoro, Andrew Tropin, Katherine Cox-Buday,
Liliana Marie Prikler
From: Peter Polidoro <peter@polidoro.io>
* gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.
Change-Id: I44de02989b8dadd4a395374fe078d4255a210028
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb3c905252..4f5aa5d1f7 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1374,6 +1374,30 @@ (define-public emacs-project-mode-line-tag
its mode line.")
(license license:gpl3+))))
+(define-public emacs-golden-ratio
+ (let ((commit "375c9f287dfad68829582c1e0a67d0c18119dab9")
+ (revision "0"))
+ (package
+ (name "emacs-golden-ratio")
+ (version (git-version "1.0.1" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/roman/golden-ratio.el")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0a635a3h6jx0clgwmhwc48i14y3xy5q29y37lp2sjnbxx1hlmkli"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/roman/golden-ratio.el")
+ (synopsis "Automatic resizing of Emacs windows to the golden ratio")
+ (description "This package provides an Emacs mode for automatically
+resizing the window that has main focus to be more convenient for editing,
+while the ones that are not being actively edited will be reduced to a smaller
+size.")
+ (license license:expat))))
+
(define-public emacs-git-modes
(package
(name "emacs-git-modes")
base-commit: 2f642b602398ab32b18faceecd074f49da92e95e
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#67905: [PATCH] gnu: Add emacs-golden-ratio.
2024-01-04 14:16 ` peter
@ 2024-01-21 23:29 ` Nicolas Goaziou via Guix-patches via
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-01-21 23:29 UTC (permalink / raw)
To: peter; +Cc: Katherine Cox-Buday, 67905-done, Liliana Marie Prikler,
Andrew Tropin
Hello,
peter@polidoro.io writes:
> From: Peter Polidoro <peter@polidoro.io>
>
> * gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-21 23:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-19 14:19 [bug#67905] [PATCH] gnu: Add emacs-golden-ratio peter
2023-12-25 16:40 ` Mathieu Othacehe
2024-01-03 19:48 ` peter
2024-01-04 10:28 ` Nicolas Goaziou via Guix-patches via
2024-01-04 14:16 ` peter
2024-01-21 23:29 ` bug#67905: " Nicolas Goaziou via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).