From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: peter@polidoro.io
Cc: Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
67905@debbugs.gnu.org,
Liliana Marie Prikler <liliana.prikler@gmail.com>,
Andrew Tropin <andrew@trop.in>
Subject: [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
Date: Thu, 04 Jan 2024 11:28:43 +0100 [thread overview]
Message-ID: <87ttntjstg.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <04930f845e48e398066caab7a1271f7525a25515.1704311285.git.peter@polidoro.io> (peter@polidoro.io's message of "Wed, 3 Jan 2024 14:48:38 -0500")
Hello,
peter@polidoro.io writes:
> From: Peter Polidoro <peter@polidoro.io>
>
> * gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.
Thank you.
> +(define-public emacs-golden-ratio
> + (package
> + (name "emacs-golden-ratio")
> + (version "20230912.1825")
The version is "1.0.1", plus a few commits. Therefore, the line above
should be:
(version (git-version "1.0.1" revision commit))
where `revision' is bound to "1" (or "0", it all depends on your
beliefs), and `commit' to "375c9f287dfad68829582c1e0a67d0c18119dab9".
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/roman/golden-ratio.el")
> + (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))
Per above, this should be bound to `revision'
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2024-01-04 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 14:19 [bug#67905] [PATCH] gnu: Add emacs-golden-ratio peter
2023-12-25 16:40 ` Mathieu Othacehe
2024-01-03 19:48 ` peter
2024-01-04 10:28 ` Nicolas Goaziou via Guix-patches via [this message]
2024-01-04 14:16 ` peter
2024-01-21 23:29 ` bug#67905: " Nicolas Goaziou via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttntjstg.fsf@nicolasgoaziou.fr \
--to=guix-patches@gnu.org \
--cc=67905@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=cox.katherine.e+guix@gmail.com \
--cc=liliana.prikler@gmail.com \
--cc=mail@nicolasgoaziou.fr \
--cc=peter@polidoro.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).